ci: optimize install_homebrew_deps by coalescing installs #4975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a couple seconds overhead for each "brew install". Refactor install_homebrew_deps.bash to first assemble the list of all packages to install, and then do a single `brew install` for the whole list. Also remove mention of packages that are pre-installed on the Mac GHA runners or that we don't need. In the process, by using the `OIIO_BREW_INSTALL_PACKAGES` variable and only setting it if empty, we now have the ability to fully override the list of packages that brew will install on a per-job basis. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
No objections for nearly a week + CI change only = merge |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 17, 2025
…twareFoundation#4975) There seems to be a couple seconds overhead for each "brew install". Refactor install_homebrew_deps.bash to first assemble the list of all packages to install, and then do a single `brew install` for the whole list. Also remove mention of packages that are pre-installed on the Mac GHA runners or that we don't need. In the process, by using the `OIIO_BREW_INSTALL_PACKAGES` variable and only setting it if empty, we now have the ability to fully override the list of packages that brew will install on a per-job basis. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a couple seconds overhead for each "brew install". Refactor install_homebrew_deps.bash to first assemble the list of all packages to install, and then do a single
brew installfor the whole list.Also remove mention of packages that are pre-installed on the Mac GHA runners or that we don't need.
In the process, by using the
OIIO_BREW_INSTALL_PACKAGESvariable and only setting it if empty, we now have the ability to fully override the list of packages that brew will install on a per-job basis.