Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change StorageDepositPerByte #1919

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Feb 23, 2022

Support for modifying StorageDepositPerByte, but if it is larger, it will return more money, the reserve balance will become to 0

@zjb0807 zjb0807 requested a review from xlc February 23, 2022 04:36
runtime/karura/src/lib.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1919 (cedf145) into master (d42d853) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
+ Coverage   85.38%   85.41%   +0.02%     
==========================================
  Files          82       81       -1     
  Lines       18241    17913     -328     
==========================================
- Hits        15575    15300     -275     
+ Misses       2666     2613      -53     
Impacted Files Coverage Δ
modules/currencies/src/lib.rs
rpc/src/lib.rs
modules/currencies/src/tests.rs
modules/nft/src/lib.rs 74.85% <0.00%> (ø)
modules/nft/src/tests.rs 99.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42d853...cedf145. Read the comment docs.

@zjb0807 zjb0807 enabled auto-merge (squash) February 23, 2022 06:06
@zjb0807 zjb0807 merged commit c1bd96c into master Feb 23, 2022
@zjb0807 zjb0807 deleted the modify-storage-deposit-per-byte branch February 23, 2022 06:08
syan095 pushed a commit that referenced this pull request Mar 8, 2022
…count

* origin/master: (21 commits)
  udpate predeploy and disable NFT precompile for karura & acala (#1942)
  remove old migrations (#1937)
  Optimized calculations t avoid error caused by division missing (#1935)
  Statemine integration test (#1712)
  switch to london (#1932)
  fix clap annotation (#1933)
  fix package name (#1928)
  type cleanup (#1931)
  bump version (#1930)
  V0.9.17 (#1924)
  update precompile set (#1929)
  bump version (#1926)
  use internal release for dev release
  fix evm-bench access_list (#1925)
  add missing precompiles and fixes (#1923)
  remove legacy trader location (#1920)
  cdp enhancement (#1886)
  add new call to execute completely fast match redeem (#1922)
  Change StorageDepositPerByte (#1919)
  add ACA to CollateralCurrencyIds (#1918)
  ...

# Conflicts:
#	Cargo.lock
#	orml
#	runtime/integration-tests/src/setup.rs
#	runtime/integration-tests/src/stable_asset.rs
#	runtime/mandala/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants