Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy trader location #1920

Merged
merged 1 commit into from
Feb 27, 2022
Merged

remove legacy trader location #1920

merged 1 commit into from
Feb 27, 2022

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented Feb 23, 2022

closes: #1917

the legacy trader location can be removed, as sibling parachain(current only bifrost) aleady upgrade to v0.9.16. if new sibling parachain want to transfer karura/acala's native asset, it should also need on v0.9.16+.

  • manual tests (Bifrost-[KUSD]->Karura)

image

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1920 (ab89d6e) into master (c1bd96c) will decrease coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1920      +/-   ##
==========================================
- Coverage   85.86%   85.41%   -0.45%     
==========================================
  Files          82       81       -1     
  Lines       18693    17913     -780     
==========================================
- Hits        16050    15300     -750     
+ Misses       2643     2613      -30     
Impacted Files Coverage Δ
modules/currencies/src/tests.rs
modules/currencies/src/lib.rs
primitives/src/currency.rs 57.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1bd96c...ab89d6e. Read the comment docs.

@zqhxuyuan zqhxuyuan requested a review from xlc February 26, 2022 15:44
@zqhxuyuan zqhxuyuan marked this pull request as ready for review February 26, 2022 15:44
@xlc xlc merged commit f6383ed into master Feb 27, 2022
@xlc xlc deleted the remove_legacy_trader_location branch February 27, 2022 01:57
syan095 pushed a commit that referenced this pull request Mar 8, 2022
…count

* origin/master: (21 commits)
  udpate predeploy and disable NFT precompile for karura & acala (#1942)
  remove old migrations (#1937)
  Optimized calculations t avoid error caused by division missing (#1935)
  Statemine integration test (#1712)
  switch to london (#1932)
  fix clap annotation (#1933)
  fix package name (#1928)
  type cleanup (#1931)
  bump version (#1930)
  V0.9.17 (#1924)
  update precompile set (#1929)
  bump version (#1926)
  use internal release for dev release
  fix evm-bench access_list (#1925)
  add missing precompiles and fixes (#1923)
  remove legacy trader location (#1920)
  cdp enhancement (#1886)
  add new call to execute completely fast match redeem (#1922)
  Change StorageDepositPerByte (#1919)
  add ACA to CollateralCurrencyIds (#1918)
  ...

# Conflicts:
#	Cargo.lock
#	orml
#	runtime/integration-tests/src/setup.rs
#	runtime/integration-tests/src/stable_asset.rs
#	runtime/mandala/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove legacy (pre 0.9.16) MultiLocation
2 participants