Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] dont recognize code as SSJS if the script tag has "language=ampscript" in it #1511

Closed
2 tasks done
JoernBerkefeld opened this issue Jul 29, 2024 · 1 comment · Fixed by #1542 or #1544
Closed
2 tasks done

[BUG] dont recognize code as SSJS if the script tag has "language=ampscript" in it #1511

JoernBerkefeld opened this issue Jul 29, 2024 · 1 comment · Fixed by #1542 or #1544
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/asset COMPONENT PRIORITY used for professional service clients
Milestone
7.1.3

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

<script runat="server" language="ampscript">
or
<script language="ampscript" runat="server">
or uppercase versions...

Expected Behavior

treat as html or ampscript and dont bother parsing.

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

7.1.1

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/asset COMPONENT labels Jul 29, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.2, 7.1.3 Jul 29, 2024
@JoernBerkefeld JoernBerkefeld added the PRIORITY used for professional service clients label Aug 1, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 2, 2024
JoernBerkefeld added a commit that referenced this issue Aug 2, 2024
@JoernBerkefeld
#1511: only allow language="javascript" (optionally), not language="a…
3bbbcf1 
…mpscript" to determine if a file SSJS or not
@JoernBerkefeld JoernBerkefeld mentioned this issue Aug 2, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Aug 2, 2024 that will close this issue
bug/1511 dont recognize code as SSJS if the script tag has "language=ampscript" in it #1542
Merged
4 tasks
@github-actions github-actions bot closed this as completed Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Closed by #1542.

@JoernBerkefeld JoernBerkefeld mentioned this issue Aug 2, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT PRIORITY used for professional service clients
Projects
None yet
Milestone
7.1.3
1 participant
@JoernBerkefeld