Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/1511 dont recognize code as SSJS if the script tag has "language=ampscript" in it #1542

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Aug 2, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/asset COMPONENT label Aug 2, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.1.3 milestone Aug 2, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 2, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Coverage Report

Commit:3bbbcf1
Base: develop@db7a606

Type Base This PR
Total Statements Coverage  70.59%  70.6%  (+0.01%)
Total Branches Coverage  69.76%  69.77%  (+0.01%)
Total Functions Coverage  82.72%  82.72%  (+0%)
Total Lines Coverage  70.59%  70.6%  (+0.01%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Journey.js  62.15%  62.79%  88.23%  62.15%
lib/util/util.js  86.38%  75.13%  95%  86.38%

@JoernBerkefeld JoernBerkefeld merged commit b49a819 into develop Aug 2, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1511-dont-recognize-code-as-ssjs-if-the-script-tag-has-language=ampscript-in-it branch August 2, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/asset COMPONENT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] dont recognize code as SSJS if the script tag has "language=ampscript" in it
1 participant