Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] when running build ask user if deploy folder should be purged before buildDefinition is executed #1805

Closed
JoernBerkefeld opened this issue Oct 25, 2024 · 3 comments · Fixed by #1815, #1820 or #1847
Closed

[Chore] when running build ask user if deploy folder should be purged before buildDefinition is executed #1805

JoernBerkefeld opened this issue Oct 25, 2024 · 3 comments · Fixed by #1815, #1820 or #1847
Assignees
@JoernBerkefeld
Labels
chore Jira issue-type "Task" e/DevOps EPIC
Milestone
7.5.0

Comments

@JoernBerkefeld
Copy link
Contributor

either i wanna keep it, or i don't, but if I don't i have the manual step of cleaning up the deploy-folder or, often times, renaming it because "I might need that later?" which I never do...

if I don't clean it up I might accidentally end up with old files
@JoernBerkefeld JoernBerkefeld added enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" e/DevOps EPIC labels Oct 25, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.5.0 milestone Oct 25, 2024
JoernBerkefeld added a commit that referenced this issue Oct 30, 2024
@JoernBerkefeld
#1805: ask to delete deploy folder when running build
8f22c6b
@JoernBerkefeld JoernBerkefeld mentioned this issue Oct 30, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Oct 30, 2024 that will close this issue
task/1805 ask to delete deploy folder when running build #1815
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld added chore Jira issue-type "Task" and removed enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" labels Oct 30, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Oct 30, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.5.0, 7.4.5 Oct 30, 2024
@JoernBerkefeld JoernBerkefeld changed the title [FEATURE] when running build ask user if deploy folder should be purged before buildDefinition is executed [Chore] when running build ask user if deploy folder should be purged before buildDefinition is executed Oct 30, 2024
@github-actions GitHub Actions
Copy link

Closed by #1815.

JoernBerkefeld added a commit that referenced this issue Oct 30, 2024
@JoernBerkefeld
#1805: filter journey builder triggeredSends from being saved to disk
361f67f
@JoernBerkefeld JoernBerkefeld reopened this Nov 1, 2024
@JoernBerkefeld
Copy link
Contributor Author

Didn't work correctly if multiple types were handed to build.

JoernBerkefeld added a commit that referenced this issue Nov 2, 2024
@JoernBerkefeld
#1805: move purge-deploy-folder logic up to handle multi-type templating
557bbaf
@JoernBerkefeld JoernBerkefeld mentioned this issue Nov 2, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Nov 2, 2024 that will close this issue
task/1805 move purge-deploy-folder logic up to handle multi-type templating #1820
Merged
4 tasks
@github-actions github-actions bot closed this as completed Nov 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

Closed by #1820.

JoernBerkefeld added a commit that referenced this issue Nov 2, 2024
@JoernBerkefeld
#1805: fix cdp's handoff of source-market to buildTemplate
36ce548
This was referenced Nov 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
chore Jira issue-type "Task" e/DevOps EPIC
Projects
None yet
Milestone
7.5.0
1 participant
@JoernBerkefeld