Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] check if correct iconUrl is set for events during deploy/retrieve #1808

Closed
JoernBerkefeld opened this issue Oct 28, 2024 · 2 comments · Fixed by #1822 or #1847
Closed

[TASK] check if correct iconUrl is set for events during deploy/retrieve #1808

JoernBerkefeld opened this issue Oct 28, 2024 · 2 comments · Fixed by #1822 or #1847
Labels
c/event COMPONENT chore Jira issue-type "Task"
Milestone
7.5.0

Comments

@JoernBerkefeld
Copy link
Contributor

saw this after a deploy:

image
@JoernBerkefeld JoernBerkefeld added c/event COMPONENT chore Jira issue-type "Task" labels Oct 28, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.4.6, 7.4.5 Oct 28, 2024
@JoernBerkefeld
Copy link
Contributor Author

saw another one, this one on a sf-triggered journey:

  • old: "iconUrl": "/jbint-events/events/SalesforceData/images/SF-Event-Icon.svg",
  • new: "iconUrl": "/events/js/salesforce-event/events/NetworkMember/images/SF-Event-Icon.svg",

chances are, SF changed the icon

JoernBerkefeld added a commit that referenced this issue Nov 4, 2024
@JoernBerkefeld
#1808: new icon for sf-triggered events
ebac837
@JoernBerkefeld JoernBerkefeld mentioned this issue Nov 4, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Nov 4, 2024 that will close this issue
Task/1808 check if correct iconurl is set for events during deployretrieve #1822
Merged
4 tasks
@github-actions github-actions bot closed this as completed Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Closed by #1822.

@JoernBerkefeld JoernBerkefeld mentioned this issue Nov 8, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/event COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.5.0
1 participant
@JoernBerkefeld