Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/1808 check if correct iconurl is set for events during deployretrieve #1822

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Nov 4, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/event COMPONENT label Nov 4, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.5 milestone Nov 4, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 4, 2024
@github-actions github-actions bot added the chore Jira issue-type "Task" label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Coverage Report

Commit:88e482a
Base: develop@82d7dc5

Type Base This PR
Total Statements Coverage  69.75%  69.75%  (+0%)
Total Branches Coverage  68.44%  68.46%  (+0.02%)
Total Functions Coverage  81.59%  81.59%  (+0%)
Total Lines Coverage  69.75%  69.75%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Event.js  54.34%  38.57%  70%  54.34%
lib/metadataTypes/MetadataType.js  82.89%  79.73%  76.54%  82.89%

@JoernBerkefeld JoernBerkefeld merged commit ea6b7fc into develop Nov 4, 2024
10 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1808-check-if-correct-iconurl-is-set-for-events-during-deployretrieve branch November 4, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/event COMPONENT chore Jira issue-type "Task"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] check if correct iconUrl is set for events during deploy/retrieve
1 participant