Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for Data Verfication activity in Automation. #325

Closed
bgacek opened this issue Jun 10, 2022 · 4 comments · Fixed by #1083 or #1094
Closed

[FEATURE] Add support for Data Verfication activity in Automation. #325

bgacek opened this issue Jun 10, 2022 · 4 comments · Fixed by #1083 or #1094
Labels
c/verification COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Milestone

Comments

@bgacek
Copy link

bgacek commented Jun 10, 2022

Is your feature request related to a problem? Please describe.

Unable to deploy the Data Verification Activity as part of my Automation.

Describe the solution you'd like

Be able to deploy the Data Verification Activity as part of my Automation deployment routine.

Describe alternatives you've considered

Manually creating and updating the activity through Automation Studio UI, or writing myself REST API requests.

Additional context

Tested myself and found out that there is an REST endpoint which allows to READ/CREATE/MODIFY the Data Verification Activities. More details below.

Endpoint: /automation/v1/dataverifications/{id}
Supported Methods: GET/POST/PATCH

Examples:

GET: /automation/v1/dataverifications/{dataVerificationDefinitionId}
Response:

{
    dataVerificationDefinitionId: 'dataVerificationDefinitionId',
    targetObjectId: 'dataExtensionObjectId',
    verificationType: 'IsEqualTo',
    value1: 0,
    value2: 0,
    shouldStopOnFailure: true,
    shouldEmailOnFailure: false,
    notificationEmailAddress: '',
    notificationEmailMessage: '',
    createdBy: userId
}

POST: /automation/v1/dataverifications/
Request:

{
  "destinationName": "Name",
  "deDestinationName": "DE Name",
  "targetObjectId": "DE Object ID",
  "deTotalRowCount": 0,
  "deFieldCount": 5,
  "deModifiedDate": "2022-04-06T15:54:14Z",
  "deModifiedByName": "Some User",
  "value1": 0,
  "conditionText1": "is",
  "conditionText2": "equal to",
  "notificationEmailAddress": "",
  "verificationType": "IsEqualTo",
  "shouldStopOnFailure": 1,
  "notificationEmailMessage": "",
  "shouldEmailOnFailure": 0
}

Response: Same as in GET Request

PATCH: /automation/v1/dataverifications/{dataVerificationDefinitionId}
Request:

{
  "dataVerificationDefinitionId": "dataVerificationDefinitionId",
  "targetObjectId": "dataExtensionObjectId",
  "verificationType": "IsEqualTo",
  "value1": 0,
  "value2": 0,
  "shouldStopOnFailure": true,
  "shouldEmailOnFailure": false,
  "notificationEmailAddress": "",
  "notificationEmailMessage": "",
  "createdBy": userId
}

Response: Same as in GET and POST

@bgacek bgacek added enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" NEW not yet analyzed new issues get this label labels Jun 10, 2022
@DougMidgley
Copy link
Contributor

@JoernBerkefeld - no generic GET collection exists for this, so would need building into automation directly, not as a separete type. We could just nest to json to avoid issues, but would need to be clever about caching etc. thoughts?

@JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld
Copy link
Contributor

looks like a bigger task for 4.1?
I do find it interesting and I sure like the groundwork done by @bgacek

@JoernBerkefeld JoernBerkefeld added this to the 4.1.0 milestone Jun 14, 2022
@JoernBerkefeld JoernBerkefeld modified the milestones: 4.2.0 , 4.3.0 Nov 22, 2022
@JoernBerkefeld JoernBerkefeld removed the NEW not yet analyzed new issues get this label label May 5, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.6.0 , 5.3.0 Aug 18, 2023
JoernBerkefeld added a commit that referenced this issue Aug 22, 2023
JoernBerkefeld added a commit that referenced this issue Aug 23, 2023
JoernBerkefeld added a commit that referenced this issue Aug 24, 2023
@github-actions
Copy link

Closed by #1083.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/verification COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
Status: Done
3 participants