Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/21 + 325 feature add support for verification activity in automation #1083

Merged
merged 24 commits into from
Aug 25, 2023
Merged

Feature/21 + 325 feature add support for verification activity in automation #1083

merged 24 commits into from
Aug 25, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Aug 19, 2023 •
edited
Loading

PR details

What changes did you make? (Give an overview)

to-dos

  • rewrite retrieve logic to cache automations first in order to get list of dataVerification items
  • add dataExtension as dependency of dataVerification
  • remove dataExtension as dependency from automation again
  • add dataVerification as dependency for automation
  • remove custom retrieve logic for dataVerification in automations
  • set dataVerifications retrieveByDefault to true
  • cache ID/key change during creation for following automation deployments in the same run
  • left out for now: (find a way to avoid step renaming for verification activities (updated name of step 1.7 in Automation 'testExisting_automation' from testExisting_dataExtension to testExisting_39f6a488-20eb-4ba0-b0b9))

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (via [TASK] Documentation for 5.3 #1081)

@JoernBerkefeld JoernBerkefeld added this to the 5.3.0 milestone Aug 19, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 19, 2023
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Aug 19, 2023
@JoernBerkefeld JoernBerkefeld added the c/verification COMPONENT label Aug 21, 2023
@JoernBerkefeld JoernBerkefeld linked an issue Aug 21, 2023 that may be closed by this pull request
[FEATURE] Add support for Data Verfication activity in Automation. #325
Closed
This was referenced Aug 21, 2023
Open
Open
@JoernBerkefeld
#325: rename from dataVerification to verification to match name in S…
c8ef433 
…FMC GUI
@JoernBerkefeld
#325: enable retrieve-all for type verification
27504e1 
via caching automations first
@JoernBerkefeld
#325: avoid SDK's getCollection method as it seems to have some kind …
6960bc7 
…of async issue
@JoernBerkefeld
#325: bundle verification retrieve logic in generic retrieveRESTcolle…
a408836 
…ction
@JoernBerkefeld
#325: upgrade Automation class to use new retrieveRESTcollection()
55a92ee
@JoernBerkefeld
#0: improve logs
bf8f6f4
@JoernBerkefeld
#325: revert require-key logic
4e62e7f
@JoernBerkefeld
#325: added tests for type verification
87dffd6
@JoernBerkefeld
#325: fix retrieve test for automation
0d437e9
@JoernBerkefeld
#325: move log msg into generic method
6cee703
@JoernBerkefeld
#325: improve test api logs
4ea2779
@JoernBerkefeld
#325: fix caching logic for automations together with verifications
1099ed4
@JoernBerkefeld
#325: fix automation tests after adding type verification
733b201
@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

Coverage Report

Commit:1b51cb6
Base: develop@832dbee

Type Base This PR
Total Statements Coverage  54.62%  55.43%  (+0.81%)
Total Branches Coverage  43.77%  44.45%  (+0.68%)
Total Functions Coverage  63.76%  64.27%  (+0.51%)
Total Lines Coverage  54.54%  55.36%  (+0.82%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld changed the title Feature/325 feature add support for data verfication activity in automation Feature/325 feature add support for verification activity in automation Aug 24, 2023
@JoernBerkefeld JoernBerkefeld added the c/automation COMPONENT label Aug 24, 2023
This was linked to issues Aug 25, 2023
[TASK] improve test-class for transactionalEmail #926
Closed
[TASK] improve test-class for journey #847
Closed
@JoernBerkefeld JoernBerkefeld mentioned this pull request Aug 25, 2023
Merged
7 tasks
@JoernBerkefeld JoernBerkefeld marked this pull request as ready for review August 25, 2023 14:09
@JoernBerkefeld JoernBerkefeld mentioned this pull request Aug 25, 2023
Closed
@JoernBerkefeld JoernBerkefeld merged commit 7ed4f63 into develop Aug 25, 2023
@JoernBerkefeld JoernBerkefeld deleted the feature/325-feature-add-support-for-data-verfication-activity-in-automation branch August 25, 2023 14:23
This was referenced Aug 25, 2023
Closed
Closed
Closed
@JoernBerkefeld JoernBerkefeld changed the title Feature/325 feature add support for verification activity in automation Feature/21 + 325 feature add support for verification activity in automation Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/automation COMPONENT c/journey COMPONENT c/transactionalEmail c/verification COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
5.3.0
1 participant
@JoernBerkefeld