Feature/139 add user deploy support #749

JoernBerkefeld · 2023-02-17T08:49:07Z

PR details

Dependencies

⚠️ awaits merge & release of PR Feature/190 support soap configure DougMidgley/SFMC-SDK#191 ⚠️
--> done with PR Bump sfmc-sdk from 0.6.3 to 0.7.0 #788

What changes did you make? (Give an overview)

closes [FEATURE] add user deploy support #139 Feature/190 support soap configure DougMidgley/SFMC-SDK#191

to dos

create / update user with basic data (key, login, name, email, notificationEmail, api-user, locked, active, mustChangePassword, DefaultBusinessUnit)
set SSO & FederationID
add global user role
remove global user role
add/ BU specific user role? --> [FEATURE] support retrieve/add/remove BU specific user role #806
add associated BU
remove associated BU
Make user permissions readable (currently IDs only) --> [FEATURE] support user permissions #772
add user permissions --> [FEATURE] support user permissions #772
remove user permissions --> [FEATURE] support user permissions #772

Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
test scripts updated
Wiki updated (via [TASK] update documentation for 5.0.0 release #722)

without roles or associated BUs

AccountUserID is required for updates, ID is not.

… instance

…e user

… user updates

JoernBerkefeld · 2023-02-22T16:10:32Z

support for removing roles added.

lib/metadataTypes/Role.js

lib/metadataTypes/definitions/Role.definition.js

# Conflicts: # docs/dist/documentation.md # lib/metadataTypes/TriggeredSend.js

…ing their ObjectID

…deploy

…getting send; refactoring

…g via SOAP

lib/metadataTypes/Role.js

lib/metadataTypes/User.js

…g via SOAP

JoernBerkefeld added 8 commits February 14, 2023 19:12

#139: add create + update support for accountUser

c421ce1

without roles or associated BUs

#139: switch central id from ID to AccountUserID

caa9d72

AccountUserID is required for updates, ID is not.

#139: support setting SSO flag and FederationID on create/update

b6866cc

#139: only save role name in accountUser JSONs as they are unique per…

85e8387

… instance

#139: support setting roles during create/update

c19f876

#139: reduced AssociatedBusinessUnits__c to an array of MIDs

83c57cf

#139: enable user creation with auto-generated passwords

99cafb2

#0: incorrect parameters for TSD.update() removed

3f18d27

JoernBerkefeld added the c/user COMPONENT label Feb 17, 2023

JoernBerkefeld added this to the 4.4.0 milestone Feb 17, 2023

JoernBerkefeld requested a review from DougMidgley February 17, 2023 08:49

JoernBerkefeld self-assigned this Feb 17, 2023

github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Feb 17, 2023

JoernBerkefeld added 4 commits February 22, 2023 15:02

Merge branch 'develop' into feature/139-add-user-deploy-support

e78ee09

#139: support for unassigning roles that were directly assigned to th…

d76f28e

…e user

#139: allow caching individual roles to avoid unassigning them during…

d83c06f

… user updates

#139: refactoring

6eddfd7

#139: fix type name

5c9571e

JoernBerkefeld linked an issue Feb 24, 2023 that may be closed by this pull request

[FEATURE] add user deploy support #139

Closed

6 tasks

JoernBerkefeld and others added 4 commits February 24, 2023 11:51

#769: add BU assignment support

c1ba8c7

#139: streamline performance and log output

128f691

Merge branch 'develop' into feature/139-add-user-deploy-support

a4589bc

#139: fix bugs during execution of document accountUser

e945676

JoernBerkefeld mentioned this pull request Feb 24, 2023

[TASK] update documentation for 5.0.0 release #722

Closed

DougMidgley reviewed Feb 28, 2023

View reviewed changes

lib/metadataTypes/Role.js Outdated Show resolved Hide resolved

lib/metadataTypes/definitions/Role.definition.js Outdated Show resolved Hide resolved

JoernBerkefeld and others added 4 commits March 10, 2023 11:17

Merge branch 'develop' into feature/139-add-user-deploy-support

a1a0adf

Merge branch 'develop' into feature/139-add-user-deploy-support

e781d71

# Conflicts: # docs/dist/documentation.md # lib/metadataTypes/TriggeredSend.js

#139: rename accountUser to user

f6d0cf9

#139: rename accountUser to user

cb1b263

JoernBerkefeld added 12 commits March 12, 2023 00:03

#139: ensure we can deploy users with "Marketing Cloud" roles by gett…

4bbb671

…ing their ObjectID

#139: add retrieve test for user

eaa65ae

#139: add deploy test for user

7bf0cf5

#798: fixes replaced MIDs in JSONs break buildTemplate

d9f8366

#139: update name to match new convention

584348e

#139: ensure preDeploy actions are executed once per item

9e31182

#139: add templating test for user

7d77638

#139: fix postDeploy BU assignment via configure

7ac61f1

#139: refactoring

e24f11a

#139: ensure BU list in retrieve folder's user.json is updated after …

d4d0b67

…deploy

#139: handle Marketing Cloud roles not being assignable via API

0208858

#139: fixing deploy test, fixing create failing due to custom fields …

a62fcc3

…getting send; refactoring

JoernBerkefeld marked this pull request as ready for review March 13, 2023 17:30

#139: allow specifying fields that should not be retrieved for cachin…

3eb662b

…g via SOAP

DougMidgley requested changes Mar 13, 2023

View reviewed changes

lib/metadataTypes/Role.js Outdated Show resolved Hide resolved

lib/metadataTypes/User.js Outdated Show resolved Hide resolved

lib/metadataTypes/User.js Outdated Show resolved Hide resolved

JoernBerkefeld added 5 commits March 14, 2023 09:24

#139: allow specifying fields that should not be retrieved for cachin…

32d9853

…g via SOAP

#139: allow specifying fields that should not be retrieved for cachin…

d3b9c1a

…g via SOAP

#139: no longer retrieve "individual roles" as they are private

cab5f3b

#139: no longer retrieve "individual roles" as they are private

5d44558

#139: pr review fixes

fcfae4f

JoernBerkefeld mentioned this pull request Mar 14, 2023

[FEATURE] support retrieve/add/remove BU specific user role #806

Open

JoernBerkefeld merged commit 65ff247 into develop Mar 14, 2023

JoernBerkefeld deleted the feature/139-add-user-deploy-support branch March 14, 2023 14:33

github-actions bot mentioned this pull request Mar 14, 2023

[FEATURE] add user deploy support #139

Closed

6 tasks

JoernBerkefeld added the BREAKING CHANGE requires increasing the major version of mcdev label May 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/139 add user deploy support #749

Feature/139 add user deploy support #749

JoernBerkefeld commented Feb 17, 2023 •

edited

Loading

JoernBerkefeld commented Feb 22, 2023

Feature/139 add user deploy support #749

Feature/139 add user deploy support #749

Conversation

JoernBerkefeld commented Feb 17, 2023 • edited Loading

PR details

Dependencies

What changes did you make? (Give an overview)

to dos

Checklist

JoernBerkefeld commented Feb 22, 2023

JoernBerkefeld commented Feb 17, 2023 •

edited

Loading