Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/139 add user deploy support #749

Merged
merged 39 commits into from
Mar 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
c421ce1
#139: add create + update support for accountUser
JoernBerkefeld Feb 14, 2023
caa9d72
#139: switch central id from ID to AccountUserID
JoernBerkefeld Feb 15, 2023
b6866cc
#139: support setting SSO flag and FederationID on create/update
JoernBerkefeld Feb 16, 2023
85e8387
#139: only save role name in accountUser JSONs as they are unique per…
JoernBerkefeld Feb 16, 2023
c19f876
#139: support setting roles during create/update
JoernBerkefeld Feb 16, 2023
83c57cf
#139: reduced AssociatedBusinessUnits__c to an array of MIDs
JoernBerkefeld Feb 16, 2023
99cafb2
#139: enable user creation with auto-generated passwords
JoernBerkefeld Feb 16, 2023
3f18d27
#0: incorrect parameters for TSD.update() removed
JoernBerkefeld Feb 17, 2023
e78ee09
Merge branch 'develop' into feature/139-add-user-deploy-support
JoernBerkefeld Feb 22, 2023
d76f28e
#139: support for unassigning roles that were directly assigned to th…
JoernBerkefeld Feb 22, 2023
d83c06f
#139: allow caching individual roles to avoid unassigning them during…
JoernBerkefeld Feb 22, 2023
6eddfd7
#139: refactoring
JoernBerkefeld Feb 22, 2023
5c9571e
#139: fix type name
JoernBerkefeld Feb 23, 2023
c1ba8c7
#769: add BU assignment support
JoernBerkefeld Feb 24, 2023
128f691
#139: streamline performance and log output
JoernBerkefeld Feb 24, 2023
a4589bc
Merge branch 'develop' into feature/139-add-user-deploy-support
JoernBerkefeld Feb 24, 2023
e945676
#139: fix bugs during execution of document accountUser
JoernBerkefeld Feb 24, 2023
a1a0adf
Merge branch 'develop' into feature/139-add-user-deploy-support
JoernBerkefeld Mar 10, 2023
e781d71
Merge branch 'develop' into feature/139-add-user-deploy-support
JoernBerkefeld Mar 11, 2023
f6d0cf9
#139: rename accountUser to user
JoernBerkefeld Mar 11, 2023
cb1b263
#139: rename accountUser to user
JoernBerkefeld Mar 11, 2023
4bbb671
#139: ensure we can deploy users with "Marketing Cloud" roles by gett…
JoernBerkefeld Mar 11, 2023
eaa65ae
#139: add retrieve test for user
JoernBerkefeld Mar 11, 2023
7bf0cf5
#139: add deploy test for user
JoernBerkefeld Mar 12, 2023
d9f8366
#798: fixes replaced MIDs in JSONs break buildTemplate
JoernBerkefeld Mar 12, 2023
584348e
#139: update name to match new convention
JoernBerkefeld Mar 12, 2023
9e31182
#139: ensure preDeploy actions are executed once per item
JoernBerkefeld Mar 12, 2023
7d77638
#139: add templating test for user
JoernBerkefeld Mar 12, 2023
7ac61f1
#139: fix postDeploy BU assignment via configure
JoernBerkefeld Mar 12, 2023
e24f11a
#139: refactoring
JoernBerkefeld Mar 13, 2023
d4d0b67
#139: ensure BU list in retrieve folder's user.json is updated after …
JoernBerkefeld Mar 13, 2023
0208858
#139: handle Marketing Cloud roles not being assignable via API
JoernBerkefeld Mar 13, 2023
a62fcc3
#139: fixing deploy test, fixing create failing due to custom fields …
JoernBerkefeld Mar 13, 2023
3eb662b
#139: allow specifying fields that should not be retrieved for cachin…
JoernBerkefeld Mar 13, 2023
32d9853
#139: allow specifying fields that should not be retrieved for cachin…
JoernBerkefeld Mar 14, 2023
d3b9c1a
#139: allow specifying fields that should not be retrieved for cachin…
JoernBerkefeld Mar 14, 2023
cab5f3b
#139: no longer retrieve "individual roles" as they are private
JoernBerkefeld Mar 14, 2023
5d44558
#139: no longer retrieve "individual roles" as they are private
JoernBerkefeld Mar 14, 2023
fcfae4f
#139: pr review fixes
JoernBerkefeld Mar 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boilerplate/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
}
},
"metaDataTypes": {
"documentOnRetrieve": ["accountUser", "automation", "dataExtension", "role"],
"documentOnRetrieve": ["user", "automation", "dataExtension", "role"],
"retrieve": []
}
}
301 changes: 205 additions & 96 deletions docs/dist/documentation.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/Deployer.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class Deployer {
*/
static async _deployBU(cred, bu, properties, typeArr, keyArr, fromRetrieve) {
const buPath = `${cred}/${bu}`;
Util.logger.info(`::Deploying ${buPath}`);
Util.logger.info(`:: Deploying to ${buPath}`);
const buObject = await Cli.getCredentialObject(properties, buPath, null, true);
let multiMetadataTypeMap;

Expand Down
2 changes: 1 addition & 1 deletion lib/MetadataTypeDefinitions.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* Provides access to all metadataType classes
*/
const MetadataTypeDefinitions = {
accountUser: require('./metadataTypes/definitions/AccountUser.definition'),
asset: require('./metadataTypes/definitions/Asset.definition'),
attributeGroup: require('./metadataTypes/definitions/AttributeGroup.definition'),
automation: require('./metadataTypes/definitions/Automation.definition'),
Expand Down Expand Up @@ -37,6 +36,7 @@ const MetadataTypeDefinitions = {
transactionalPush: require('./metadataTypes/definitions/TransactionalPush.definition'),
transactionalSMS: require('./metadataTypes/definitions/TransactionalSMS.definition'),
triggeredSend: require('./metadataTypes/definitions/TriggeredSend.definition'),
user: require('./metadataTypes/definitions/User.definition'),
};

module.exports = MetadataTypeDefinitions;
2 changes: 1 addition & 1 deletion lib/MetadataTypeInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* Provides access to all metadataType classes
*/
const MetadataTypeInfo = {
accountUser: require('./metadataTypes/AccountUser'),
asset: require('./metadataTypes/Asset'),
attributeGroup: require('./metadataTypes/AttributeGroup'),
automation: require('./metadataTypes/Automation'),
Expand Down Expand Up @@ -37,6 +36,7 @@ const MetadataTypeInfo = {
transactionalPush: require('./metadataTypes/TransactionalPush'),
transactionalSMS: require('./metadataTypes/TransactionalSMS'),
triggeredSend: require('./metadataTypes/TriggeredSend'),
user: require('./metadataTypes/User'),
};

module.exports = MetadataTypeInfo;
3 changes: 2 additions & 1 deletion lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ class Mcdev {
event: 'eventDefinition',
fileLocation: 'ftpLocation',
triggeredSend: 'triggeredSendDefinition',
user: 'accountUser',
};
Util.logger.info(`\n :: Retrieving ${cred}/${bu}\n`);
const retrieveTypesArr = [];
Expand Down Expand Up @@ -364,7 +365,7 @@ class Mcdev {
return;
}
try {
const parentBUOnlyTypes = ['accountUser', 'role'];
const parentBUOnlyTypes = ['user', 'role'];
const buObject = await Cli.getCredentialObject(
properties,
parentBUOnlyTypes.includes(type) ? businessUnit.split('/')[0] : businessUnit,
Expand Down
Loading