Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sockets - Kelly #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets - Kelly #18

wants to merge 1 commit into from

Conversation

kdow
Copy link

@kdow kdow commented Apr 9, 2019

No description provided.

CheezItMan
CheezItMan reviewed May 13, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you have a good iterative solution here. You also have the time complexity correctly noted. See my note on the space complexity.

lib/factorial.rb
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) where n is the value of the input number
# Space complexity: O(1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the space complexity is O(n) because every time you make a method call, and you're making ~n of them, Ruby puts the current method in memory on something called the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdow @CheezItMan