Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Kelly #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets - Kelly #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/factorial.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# Computes factorial of the input number and returns it
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) where n is the value of the input number
# Space complexity: O(1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the space complexity is O(n) because every time you make a method call, and you're making ~n of them, Ruby puts the current method in memory on something called the stack.

def factorial(number)
raise NotImplementedError
unless number
raise ArgumentError, "Non-number entered."
end
if number == 1 || number == 0
return 1
else
number * factorial(number - 1)
end
end