cedar mac #67
Draft
cedar mac #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccaelenzil
reviewed
Dec 6, 2021
| @@ -1,12 +1,41 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
It is a convention to put the index.html at the project root directory level and additional pages in a directory such as pages
| <p>Lorem ipsum MAC dolor sit amet consectetur, adipisicing elit MAC.</p> | ||
| </main> | ||
|
|
||
| <footer> |
There was a problem hiding this comment.
Hrmm, somehow I don't see this on the rendered page
| </footer> | ||
|
|
||
| <section class="showcase"> | ||
| <video src="./videos/pexels-video-lava.mp4" muted loop autoplay></video> |
| position: absolute; | ||
| left: -9999px; | ||
| } | ||
| .menu-icon:checked + label, |
There was a problem hiding this comment.
Nice work implementing this menu feature!
| .nav ul li:nth-child(4){ | ||
| transition-delay: 50ms; | ||
| } | ||
| .nav ul li a{ |
There was a problem hiding this comment.
This selector is getting a bit complex. You might consider using a more specific class name to simplify here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions
Why is it important to consider and use semantic HTML? |
I don't feel like I did this very well, but using semantic HTML keeps things clear and organized.
How did you decide to structure your CSS? |
I went with an abstract/chaotic CSS structure.
What was the most challenging piece of this assignment? |
Honestly, I am not pleased with the end result of this project. I have no experience with HTML/CSS, but for some reason thought that it would be easy peasy, so I chose to work on other things and got a very late start. Turns out that if you want to make something that isn't lame, it can actually be quite time consuming and tricky!
I didn't really finish the assignment and am not happy with what I was able to complete. Next time I will spend more time on it and make the best website ever.
Describe one area that you gained more clarity on when completing this assignment |
It is clear to me now that a beginner cannot simply make a sick website in one day.
Optional |
Did you deploy to GitHub Pages? If so, what is the URL to your website? |
https://mac-madison.github.io/personal-portfolio-site/pages/index.html
(The corner bubble is the nav, click it to go to other pages)