Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cedar mac #67

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,33 @@ Congratulations! You're submitting your assignment!
Question | Answer
:------------- | :-------------
Did you have to resolve any issues when running the HTML Validator? If so, what were they? |
Yes, a few stragglers.


Why is it important to consider and use semantic HTML? |
I dont feel like I did this very well,
but using semantic HTML keeps things clear and organized.


How did you decide to structure your CSS? |
I went with an abstract/chaotic CSS structure.

What was the most challenging piece of this assignment? |
Honestly, I am not pleased with the end result of this project.
I have no experience with HTML/CSS, but for some reason thought
that it would be easy peasy, so I chose to work on other things
and got a very late start.
Turns out that if you want to make something that isnt lame,
it can actually be quite time consuming and tricky!
I didnt really finish the assignment and am not happy
with what I was able to complete.
Next time I will spend more time on it and make the best website ever.

Describe one area that you gained more clarity on when completing this assignment |
It is clear to me now that a beginner cannot make a sick website in one day.

**Optional** |
Did you deploy to GitHub Pages? If so, what is the URL to your website? |
https://mac-madison.github.io/personal-portfolio-site/pages/index.html

*!!!!The corner bubble is the nav, click it!!!!*
15 changes: 15 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "pwa-chrome",
"request": "launch",
"name": "Launch Chrome against localhost",
"url": "http://localhost:8080",
"webRoot": "${workspaceFolder}"
}
]
}
39 changes: 37 additions & 2 deletions pages/about.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,47 @@
<!DOCTYPE html>
<html lang="en">

<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<link rel="stylesheet" href="../styles/about.css">
<title>about</title>
</head>

<body>



<header>
about
</header>
<main>
<p>mac lorem ipsum dolor sit amet consectetur adipisicing elit. Excepturi Mac porro, facere laboriosam quasi minima
doloremque.<br><br>Lorem ipsum Mac dolor sit amet consectetur adipisicing elit. Labore, deleniti! MAC lorem ipsum
dolor sit amet consectetur adipis
</p>

</main>


<section class="showcase">


<video src="./videos/pexels-ryutaro-tsukata-5471911.mp4" muted loop autoplay></video>
<div class="overlay">
</div>
<input class="menu-icon" type="checkbox" id="menu-icon" name="menu-icon" />
<label for="menu-icon"></label>

<nav class="nav">
<ul class="pt-5">

<li><a href="index.html">Home</a></li>
<li><a href="portfolio.html">Portfolio</a></li>
</ul>
</nav>
</section>

</body>

</html>
33 changes: 31 additions & 2 deletions pages/index.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,41 @@
<!DOCTYPE html>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a convention to put the index.html at the project root directory level and additional pages in a directory such as pages

<html lang="en">

<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<link rel="stylesheet" href="../styles/index.css">
<title>home</title>
</head>

<body>

<header>
<h1>mac</h1>
</header>
<main>
<p>Lorem ipsum MAC dolor sit amet consectetur, adipisicing elit MAC.</p>
</main>

<footer>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmm, somehow I don't see this on the rendered page

<h3>call now! 1-800-mac</h3>
</footer>

<section class="showcase">
<video src="./videos/pexels-video-lava.mp4" muted loop autoplay></video>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool video background!

<div class="overlay">
</div>
<input class="menu-icon" type="checkbox" id="menu-icon" name="menu-icon" />
<label for="menu-icon"></label>

<nav class="nav">
<ul class="pt-5">
<li><a href="about.html">About</a></li>
<li><a href="portfolio.html">Portfolio</a></li>
</ul>
</nav>
</section>

</body>

</html>
27 changes: 25 additions & 2 deletions pages/portfolio.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,35 @@
<!DOCTYPE html>
<html lang="en">

<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<link rel="stylesheet" href="../styles/portfolio.css">
<title>PORTFOLIO</title>
</head>

<body>


<section class="showcase">

<video src="./videos/pexels-mart-production-7565441.mp4" muted loop autoplay></video>
<div class="overlay">
<h1>COMING SOON COMING SOON COMING SOON COMING SOON COMING SOON COMING SOON COMING SOON COMING SOON COMING SOON
COMING SOON COMING SOON COMING SOON </h1>
</div>

<input class="menu-icon" type="checkbox" id="menu-icon" name="menu-icon" />
<label for="menu-icon"></label>
<nav class="nav">
<ul class="pt-5">

<li><a href="index.html">Home</a></li>
<li><a href="about.html">About</a></li>
</ul>
</nav>
</section>

</body>

</html>
Binary file added pages/videos/pexels-mart-production-7565441.mp4
Binary file not shown.
Binary file added pages/videos/pexels-ryutaro-tsukata-5471911.mp4
Binary file not shown.
Binary file added pages/videos/pexels-video-lava.mp4
Binary file not shown.
Loading