Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork Sync: Update from parent repository #469

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

AdamL-Microsoft
Copy link
Owner

No description provided.

#3553)

* Release 8.7.1 (hotfix) (#3459)

* Remove the retention policy setting (#3452)

---------

Co-authored-by: Cheick Keita <chkeita@microsoft.com>

* Revert "Release 8.7.1 (hotfix) (#3459)" (#3468)

This reverts commit c69deed.

* Add a ToExpand trait

* Implement ToExpand for CommonConfig

* Rename to GetExpand and implement for all task configs

* Add proptest to the crate and a simple test function (broken)

* Fix import issues

* Add config tests for analysis task

* Implement tests for merge task

* Return Result from get_expand() and implement for the rest of the configs

* Resolve merge conflict

* Undo comment

* Update comments

* Undo unintentional changes

* Add missing newline

* Fix build checks

* Fix build checks - lifetime elision

* Fix linux test imports

* Fix indented line

* Fix build checks

* Replace common test code with a declarative macro

* Format code

* Simplify URL arbitrary even further to guarantee that it's parseable

* Upgrade proptest version

* Implement Default for CommonConfig

* Remove the GetExpand trait

* Return Expand instead of Result<Expand>

* cargo fmt

* Remove unused import

* Fix PR comments (see full message for details)

- Stop initializing target_exe in get_expand() for the dotnet coverage task
  since it's overwritten when the expander is used.
 - Expand the inputs field from the generic merge task as generated_inputs.

* Update dotnet coverage task Expander tests

* Remove incorrect expansion variable from generic merge task

---------

Co-authored-by: Adam <103067949+AdamL-Microsoft@users.noreply.github.com>
Co-authored-by: Cheick Keita <chkeita@microsoft.com>
@AdamL-Microsoft AdamL-Microsoft merged commit 29fd625 into AdamL-Microsoft:main Oct 19, 2023
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants