-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show coin node version where available #600
Conversation
PaulDremanovich
commented
Feb 23, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deployed to https://msg-adamant-pr-600.surge.sh 🚀 |
Confirm that:
Update:
@confleux |
Yes. It will be called only once, when an instance of node is created. |
Resolved CORS on btcnode2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't do this.
The app takes minVersion
from adamant-wallets
repository.
Revert the PR.
The correct fix for the issue is don't show node version if we didn't get a reply from a node (as in case of Unsupported
).
a8eef25
to
8e7a692
Compare
Successfully tore down https://msg-adamant-pr-600.surge.sh 🥲 |