Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show coin node version where available #600

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

PaulDremanovich
Copy link
Member

Screenshot from 2024-02-23 12-40-00

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 9:33am

Copy link

github-actions bot commented Feb 23, 2024

Deployed to https://msg-adamant-pr-600.surge.sh 🚀

@adamant-al
Copy link
Member

Confirm that:

  • There are no regular requests to check node versions. The only time the app receives versions is on app start.

Update:

@confleux
Check why https://btcnode2.adamant.im/bitcoind doesn't work.
It seems some CORS issue.

src/lib/nodes/btc/BtcNode.ts Outdated Show resolved Hide resolved
src/lib/nodes/btc/BtcNode.ts Outdated Show resolved Hide resolved
src/lib/nodes/btc/BtcNode.ts Outdated Show resolved Hide resolved
src/lib/nodes/dash/DashNode.ts Outdated Show resolved Hide resolved
src/lib/nodes/dash/DashNode.ts Outdated Show resolved Hide resolved
src/lib/nodes/doge/DogeNode.ts Outdated Show resolved Hide resolved
src/lib/nodes/doge/DogeNode.ts Outdated Show resolved Hide resolved
src/lib/nodes/eth/EthNode.ts Outdated Show resolved Hide resolved
@bludnic
Copy link
Member

bludnic commented Feb 26, 2024

There are no regular requests to check node versions. The only time the app receives versions is on app start.

Yes. It will be called only once, when an instance of node is created.

@confleux
Copy link
Member

confleux commented Feb 26, 2024

@confleux Check why https://btcnode2.adamant.im/bitcoind doesn't work. It seems some CORS issue.

Resolved CORS on btcnode2

@PaulDremanovich
Copy link
Member Author

@PaulDremanovich
Copy link
Member Author

Now the list of nodes looks like this:
Screenshot from 2024-02-26 22-32-11

@adamant-al
Copy link
Member

adamant-al commented Feb 27, 2024

image

If you can't receive version, it will be empty.
"0.8.0" is not a correct versioning ⟶ "v0.8.0".

(See unsupported ADM nodes)

Copy link
Member

@adamant-al adamant-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do this.
The app takes minVersion from adamant-wallets repository.
Revert the PR.

The correct fix for the issue is don't show node version if we didn't get a reply from a node (as in case of Unsupported).

src/lib/nodes/btc/BtcNode.ts Outdated Show resolved Hide resolved
src/lib/nodes/dash/DashNode.ts Outdated Show resolved Hide resolved
src/lib/nodes/utils/nodeVersionFormatters.ts Outdated Show resolved Hide resolved
src/lib/nodes/utils/nodeVersionFormatters.ts Outdated Show resolved Hide resolved
src/lib/nodes/utils/nodeVersionFormatters.ts Outdated Show resolved Hide resolved
src/lib/nodes/eth/EthNode.ts Outdated Show resolved Hide resolved
@bludnic bludnic merged commit 88869f0 into dev Mar 4, 2024
3 checks passed
@bludnic bludnic deleted the feat/coin-node-version branch March 4, 2024 17:01
Copy link

github-actions bot commented Mar 4, 2024

Successfully tore down https://msg-adamant-pr-600.surge.sh 🥲

@RealGoodProgrammer RealGoodProgrammer mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants