Reverted some changes that shouldnt be committed and fixed some stuff #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Barsonax
commented
Apr 22, 2020
•
Barsonax
commented
- Reverted some changes from Moving package management to a csproj #786 that shouldn't have been committed.
- Made it possible for the nightly builder to handle prerelease suffixes in nuget versions. For example 4.0.0-alpha.
- Fixed path to nunit.exe to be nunit3-console.exe so that it now works. I think eventually we want to use tools like this in a more clean way (without having to commit files like these to source control, depend on hardcoded paths, locally installed tools etc) but thats something for Move from the legacy nightlybuilder tool to more modern tooling #718
- Projects in tools now use net framework 4.7.2 instead of 4.5.2 so that this is now consistent with all other net framework projects.
Barsonax
changed the title
Barsonax
referenced
this pull request
Apr 22, 2020
…ckage management (#789) #CHANGE: Removed package manager and new project logic in favor of csproj based package management, bumped version to 4.0.0-alpha
… to use nuget versions with a prerelease suffix in the nightlybuilder
Barsonax
force-pushed
the
feature/nightlybuilderfix
branch
from
d7f8975 to
f4fc520
Compare
SirePi
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.