Add test for consistency plotting; fix plotting for unordered dataset ids #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
stes
commented
Jul 31, 2023
Comment on lines
-329
to
+353
| dataset_ids = ["achilles", "buddy", "buddy", "achilles"] | ||
| dataset_ids = ["achilles", "buddy", "cicero", "gatsby"] | ||
| dataset_ids_runs = ["achilles", "buddy", "buddy", "achilles"] |
There was a problem hiding this comment.
Still TODO: Would be good to double check that the previous format with repeated datasets, ["achilles", "buddy", "buddy", "achilles"] does indeed not make sense when plotting the consistency matrix --- if both this behavior plus #27 should be supported, we need additional internal changes to the plot (e.g., how numbers should be averaged during plotting).
|
close in favor of #87 , thanks @CeliaBenquet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #27, when passing non-sorted labels to the consistency plot, the order off values in the confusion matrix does not match the axis labels.
In this PR,
cebra_sklearn_metrics.consistency_score(...,between="datasets",...)to detect this issueBefore merging, it would be good to add additional tests especially for the multi-run (vs. multi-dataset) case. Also useful if @CeliaBenquet could review this remaining comment (https://github.com/AdaptiveMotorControlLab/CEBRA/pull/54/files#r1279777840).
Fix #27