Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consistency labels ordering and simplify #87

Merged

Conversation

CeliaBenquet
Copy link
Member

@CeliaBenquet CeliaBenquet commented Oct 3, 2023

  • I removed the possibility of using both the between-runs and between-datasets at the same time.
  • I removed the possibility to add dataset_ids for the between-runs consistency. The labels will be np.arange(len(embeddings)) always.
  • The embeddings provided for between-runs must be the same number of samples (as no alignment is happening), but the number of output dimensions can be different.
  • I re-wrote the tests: 2 functions one for each (datasets / runs).
  • I re-wrote some of the examples in the usage file so that the tests pass.

to do:
Maybe need better documentation in the usage file for instance.


Fix #27
Fix #54

@cla-bot cla-bot bot added the CLA signed label Oct 3, 2023
@CeliaBenquet CeliaBenquet requested review from stes and gonlairo October 3, 2023 14:37
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can close other PR and use this

@stes stes changed the base branch from stes/fix-consistency-plot to main October 3, 2023 15:13
@stes stes merged commit 09ad1e4 into AdaptiveMotorControlLab:main Oct 3, 2023
9 checks passed
@stes stes deleted the celia/fix-consistency-ids branch October 3, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label sorting bug in consistency score
3 participants