Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings panel opens at login (again!) [same as closed #746] #853

Closed
4 tasks done
Perifractic opened this issue May 25, 2023 · 37 comments
Closed
4 tasks done

Settings panel opens at login (again!) [same as closed #746] #853

Perifractic opened this issue May 25, 2023 · 37 comments

Comments

@Perifractic
Copy link

Perifractic commented May 25, 2023

The bug with settings panel opening at login has returned. Previously has been fixed in #746.

The settings panel opens every time the Mac wakes, requiring the user to close the AdGuard window every time they sit down at their computer.

Original text

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I made sure all content blockers are enabled in Safari settings
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

1.11.13

Environment

Safari / Mac

What filters do you have enabled?

No response

Issue Details

You have once again reintroduced the exact same bug from closed bug #746 where the settings panel opens every time the Mac wakes, requiring the user to close the AdGuard window every time they sit down at their computer.

This was solved before, then broken again, then solved again, then the bug closed (746), now you've broken it again.

Whoever keeps reintroducing this bug, please stop them! It is beyond frustrating.

AdGuard is meant to stop annoying popups and ads, yet AdGuard ITSELF has BECOME an annoying popup. I have to close it perhaps 10 times a day. Please urgently fix, and fix forever.

Expected Behavior

See above and #746

Actual Behavior

See above and #746

Screenshots

See #746

Additional Information

No response

@Versty
Copy link
Contributor

Versty commented May 28, 2023

@Perifractic Hi! What is your MacOS version?
We have tried to reproduce this issue with 13.3.1, but to no avail. Works fine on our side.

Also, we would like you to check if the com.adguard.safari.AdGuard.plist file is in the list in the ~/Library/Preferences folder on your device. (Open Finder -> Press command+shift+G -> enter ~/Library/Preferences)

@Perifractic
Copy link
Author

Last time this happened you also said you couldn't reproduce it, then eventually fixed it. Then unfixed it.

I have 13.4 (22F66).

There is no AdGuard file in Preferences.

As others are now also reporting the bug is not fixed, I doubt it's an issue with my system.

@timlockridge
Copy link

I too have this problem. It was fixed for a while but has now returned. I'm now closing the settings window several times a day.

@Versty
Copy link
Contributor

Versty commented May 30, 2023

@timlockridge Could you specify your MacOS version, chip and Safari version?

@EvanGrote
Copy link

I'm seeing this behavior on both of my macOS devices:

MacOS Version: Ventura 13.4
Chip: M2 Pro
Safari Version: 16.5 (18615.2.9.11.4)

MacOS Version: Ventura 13.4
Chip: M2
Safari Version: 16.5 (18615.2.9.11.4)

@timlockridge
Copy link

@timlockridge Could you specify your MacOS version, chip and Safari version?

MacOS Version: Ventura 13.4
Chip: 3.4 GHz Quad-Core Intel Core i5
Safari Version: Version 16.5 (18615.2.9.11.4)

@Versty
Copy link
Contributor

Versty commented May 30, 2023

@timlockridge @EvanGrote Thank you!

Have you updated from the previous version or installed the application for the first time?

@EvanGrote
Copy link

I updated from the previous version. Currently running Version 1.11.13 (build 297, CT 2.0.39)

@timlockridge
Copy link

I updated from the previous version. Currently running Version 1.11.13 (build 297, CT 2.0.39)

Same here

@Versty
Copy link
Contributor

Versty commented Jun 19, 2023

@Perifractic @EvanGrote @timlockridge
Please make sure that AdGuard for Safari is not in the Open at Login list in the system settings.

System settings -> General -> Login items

@Richipedia
Copy link

Richipedia commented Jun 20, 2023

Seeing this again on my system too. It was fixed for a while but now is happening when my Mac wakes from sleep.

macOS version: 13.4 (22F66)
Safari version: 16.5 (18615.2.9.11.4)
AdGuard version: 1.11.12 (build 289, CT 2.0.34)
Chip: Apple M1 Max

I can confirm that AdGuard for Safari is not listed in Open at Login in my System Settings.

I have submitted by AdGuard logs via email per the instructions in issue #860.

@Versty
Copy link
Contributor

Versty commented Jun 20, 2023

@Richipedia Thanks! Got the logs from you.

@sonnykt
Copy link

sonnykt commented Jul 25, 2023

The settings window not only opens when my mac wakes up but also at random time during the day while I am using the mac.

macOS version 13.4.1 (c) (22F770820d)
Safari Version 16.5.2 (18615.2.9.11.10)
AdGuard version: Version 1.11.12 (build 289, CT 2.0.34)

@probably-carly
Copy link

I also have this issue, it's rather bothersome as I almost never want to see the settings panel. This should be a "set it and forget it" situation.

macOS version 13.4.1 (22F82)
Safari Version 16.5.2 (18615.2.9.11.10)
AdGuard version 1.11.12 (build 289, CT 2.0.34)

Happy to provide any extra details.

@Perifractic
Copy link
Author

It just started happening AGAIN 2 days ago. This is getting beyond ridiculous. Please address this at a high level with your engineers.

@huyfm
Copy link

huyfm commented Aug 5, 2023

Confirmed. It's back. The window shows up when I wake up my Mac.

@pawelwiejkut
Copy link

Same for me. Issue is back.

@yd021976
Copy link

yd021976 commented Aug 9, 2023

Hi all, same here. The control panel opens randomly in the day. Either after I wake up my Mac from sleep, either when I'm using it.

@hch0u
Copy link

hch0u commented Aug 14, 2023

Same issue here.

AdGuard version: 1.11.13 (build 297, CT 2.0.39)
Safari version: 16.6 (18615.3.12.11.2)
macOS version: 13.5 (22G74)

@hch0u
Copy link

hch0u commented Aug 14, 2023

Same issue here.

AdGuard version: 1.11.13 (build 297, CT 2.0.39)
Safari version: 16.6 (18615.3.12.11.2)
macOS version: 13.5 (22G74)

Updated to Version 1.11.14 (build 301, CT 2.0.41), issue persists.

@alexx7311
Copy link

@benfischer1 @prophoto @hch0u @yd021976 @pawelwiejkut @huyfam @Perifractic @probably-carly1 @sonnykt @Richipedia @Perifractic @EvanGrote @timlockridge

Please do the following:

  1. Open Terminal: You can find Terminal in the Utilities folder within the Applications folder.

  2. Enter the Following Command:
    /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister -dump > lsregister_dump.txt

  3. Run the Command: Press Enter to execute the command. This will dump the data and save it into a file named lsregister_dump.txt in the current directory.

  4. Optional: If you encounter permission issues, prepend the command with sudo and then enter your password when prompted.

Then navigate to the current directory in the Terminal or Finder, find lsregister_dump.txt and send the file to apple@adguard.com and mention in the subject the issue number 853

@EvanGrote
Copy link

@alexx7311 Sent 👍🏽

@alexx7311
Copy link

@benfischer1 @prophoto @hch0u @yd021976 @pawelwiejkut @huyfam @Perifractic @probably-carly1 @sonnykt @Richipedia @Perifractic @EvanGrote @timlockridge

Do you close this window before restart?

Screenshot 1

Screenshot

Does the AdGuard window with settings appear every time you restart your system?

Please send a video of reproducing the problem if possible.

Also please do the following:

  1. Restart your system to reproduce the problem
  2. Once you see the AdGuard for Safari settings window open (no more than 10 minutes should pass, otherwise the log will not contain the necessary information), open Terminal and type the following:
    log show --info --last 10m | grep -i "adguard" > log.txt
  3. Press Enter to execute the command.
  4. Open AdGuard for Safari settings > General > 'Export logs' > 'Save'

Then find log.txt file and saved AdGuard for Safari logs and send them to apple@adguard.com and mention in the subject the issue number 853

@emmetbroaders
Copy link

It is incredible that so many people are having this issue and the official response for years has been "huh, weird"

@Perifractic
Copy link
Author

I have to agree. The way you guys are handling this tiny bug is bizarre. It's been open for one year today (original ticket: #746 )

It's quite simple: If I leave the Mac alone (even with the screen on!) for around 10 minutes, the AdGuard window pops up. So you guys just need to figure out what you're triggering when there's no mouse activity for 10 mins. Then stop that.

@Versty
Copy link
Contributor

Versty commented Oct 3, 2023

@Perifractic @emmetbroaders @EvanGrote @hch0u @pawelwiejkut @yd021976 @Richipedia @huyfam @probably-carly @sonnykt @timlockridge

Hi everyone!

We understand your feelings and have done our best to fix this bug (again!). Beta version (1.11.15) is already available to test in the TestFlight. Starting from this version, AdGuard for Safari will launch in the background in most scenarios, random popups of the settings window should be gone as well.
Feel free to try it out and share any feedback.

How to join beta

@Otider
Copy link

Otider commented Oct 5, 2023

Experiencing this issue on a MacBook Pro M1 running Ventura 13.5.2 (22G91), Safari Version 16.6 (18615.3.12.11.2), Ad Guard Version 1.11.13 (build 297, CT 2.0.39). Settings window pops up every time I restart. Please fix.

@Versty
Copy link
Contributor

Versty commented Oct 9, 2023

@Otider Please update to the latest version (AdGuard for Safari 1.11.15) and let us know the result.

@yd021976
Copy link

Upgraded to latest version. After two days, no setting window when login or awake my mac.
Seems to be fixed.
Thank you !

@collectttive
Copy link

It is not fixed.

@sonnykt
Copy link

sonnykt commented Oct 15, 2023

It's still happening on Version 1.11.12 (build 289, CT 2.0.34) with latest Safari on macOS Sonoma.

@yd021976
Copy link

Hi, I confirm that with version 1.11.15 (and not 1.11.12 that is not the last version), the bug is fixed for me. No more setting window appearing since installing v1.11.15 (five or six days ago).
My environnement is : Mac mini M2 pro, MacOS Sonoma, Safari 17.0, Adguard for Safari v1.11.15
@sonnykt : It seems you tested with 1.11.12 that is not the last version. Try with 1.11.15
@collectttive : Wich version of AdGuard for safari are you using ?

@Perifractic
Copy link
Author

Perifractic commented Oct 16, 2023

@Versty Edit: To anyone looking to update to 1.11.15 open the App Store on Mac then go to Updates

@emmetbroaders
Copy link

@Versty Maybe it would be helpful to write here how to update AdGuard on Safari. There is no "Update" option to be found in the app or Safari settings. Only "Uninstall".

@Perifractic App Store pal

@Perifractic
Copy link
Author

@emmetbroaders Thanks! There was me searching the actual app and Safari settings, totally forgetting extensions are in the App Store now.

@prophoto
Copy link

People are awful rude around here. Sad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests