Skip to content

Commit

Permalink
#184 assistant layout
Browse files Browse the repository at this point in the history
  • Loading branch information
Mizzick committed Mar 10, 2016
1 parent da410c1 commit ceb9361
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 153 deletions.
6 changes: 3 additions & 3 deletions Extension/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,13 @@
"message": "Advanced settings..."
},
"assistant_apply_rule_to_all_sites": {
"message": "Apply this rule to&nbsp;every web site<input id='oneDomainRadio' type='checkbox' class='checkbox'>"
"message": "Apply this rule to&nbsp;every web site"
},
"assistant_block_by_reference": {
"message": "Block element by&nbsp;url<input id='blockByUrl' type='checkbox' class='checkbox'>"
"message": "Block element by&nbsp;url"
},
"assistant_block_similar": {
"message": "Block similar elements<input id='blockSimilar' type='checkbox' class='checkbox'>"
"message": "Block similar elements"
},
"assistant_block": {
"message": "Block"
Expand Down
1 change: 0 additions & 1 deletion Extension/browser/chrome/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
"lib/content-script/i18n-helper.js",
"lib/content-script/assistant/js/adguard-selector.js",
"lib/content-script/assistant/js/adguard-rules-constructor.js",
"lib/content-script/assistant/js/tools.js",
"lib/content-script/assistant/js/assistant.js",
"lib/content-script/assistant/js/start-assistant.js"
],
Expand Down
1 change: 0 additions & 1 deletion Extension/browser/firefox/lib/contentScripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ ContentScripts.prototype = {
'content-script/i18n-helper.js', // Localization placeholders
'content-script/content-script.js', // Message passing
'content-script/assistant/js/start-assistant.js',
'content-script/assistant/js/tools.js',
'content-script/assistant/js/adguard-selector.js',
'content-script/assistant/js/adguard-rules-constructor.js',
'content-script/assistant/js/assistant.js'
Expand Down
1 change: 0 additions & 1 deletion Extension/browser/safari/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
<string>lib/content-script/assistant/js/adguard-selector.js</string>
<string>lib/content-script/assistant/js/adguard-rules-constructor.js</string>
<string>lib/content-script/assistant/js/assistant.js</string>
<string>lib/content-script/assistant/js/tools.js</string>
<string>lib/content-script/assistant/js/start-assistant.js</string>
<string>lib/content-script/subscribe.js</string>
</array>
Expand Down
22 changes: 6 additions & 16 deletions Extension/lib/content-script/assistant/js/assistant.js
Original file line number Diff line number Diff line change
Expand Up @@ -360,11 +360,6 @@ var Adguard = function () {
});
};

var makeRadioButtonsAndCheckBoxes = function () {
findInIframe('.radiobox').radioButton();
findInIframe('.checkbox').checkbox();
};

var onCancelSelectModeClicked = function (e) {
e.preventDefault();

Expand Down Expand Up @@ -446,18 +441,18 @@ var Adguard = function () {
).append($('<div>', {id: 'adv-settings', "class": 'element-rule_form'})
.append($('<div>', {"class": 'element-rule_form-cont'})
.append($('<div>', {id: 'one-domain-p', "class": 'element-rule_fieldset'})
.append($('<input>', {type:'checkbox', "class": 'form-ui-control'}))
.append($('<label>', {"class": 'form-ui'})
.append($('<input>', {id:'oneDomainRadio', type:'checkbox', "class": 'form-ui-control checkbox'}))
.append($('<label>', {"class": 'form-ui', "for":'oneDomainRadio'})
.append($('<span>', {"class": 'form-ui-txt', i18n: 'assistant_apply_rule_to_all_sites'}))
)
).append($('<div>', {id: 'block-by-url-p', "class": 'element-rule_fieldset', style: 'display: none;'})
.append($('<input>', {type:'checkbox', "class": 'form-ui-control'}))
.append($('<label>', {"class": 'form-ui'})
.append($('<input>', {id:'blockByUrl', type:'checkbox', "class": 'form-ui-control checkbox'}))
.append($('<label>', {"class": 'form-ui', "for":'blockByUrl'})
.append($('<span>', {"class": 'form-ui-txt', i18n: 'assistant_block_by_reference'}))
)
).append($('<div>', {id: 'block-similar-p',"class": 'element-rule_fieldset', style: 'display: none;'})
.append($('<input>', {type:'checkbox', "class": 'form-ui-control'}))
.append($('<label>', {"class": 'form-ui'})
.append($('<input>', {id:'blockSimilar', type:'checkbox', "class": 'form-ui-control checkbox'}))
.append($('<label>', {"class": 'form-ui', "for":'blockSimilar'})
.append($('<span>', {"class": 'form-ui-txt', i18n: 'assistant_block_similar'}))
)
).append($('<div>', {"class": 'element-rule_fieldset'})
Expand Down Expand Up @@ -533,7 +528,6 @@ var Adguard = function () {
d.resolve('');
}, function () {
localizeMenu();
makeRadioButtonsAndCheckBoxes();
});
return d;
};
Expand Down Expand Up @@ -765,7 +759,6 @@ var Adguard = function () {

makeDefaultCheckboxesForDetailedMenu();
onScopeChange();
makeRadioButtonsAndCheckBoxes();
handleShowBlockSettings(haveUrlBlockParameter(element), haveClassAttribute(element));
};

Expand All @@ -774,9 +767,6 @@ var Adguard = function () {
findInIframe('#blockByUrl').attr('checked', false);
findInIframe('#blockSimilar').attr('checked', false);
findInIframe('#oneDomainRadio').attr('checked', false);
findInIframe('#block-by-url-p >div >span').removeClass('active');
findInIframe('#block-similar-p >div >span').removeClass('active');
findInIframe('#one-domain-p >div >span').removeClass('active');
};

var getUrlBlockAttribute = function (element) {
Expand Down
131 changes: 0 additions & 131 deletions Extension/lib/content-script/assistant/js/tools.js

This file was deleted.

0 comments on commit ceb9361

Please sign in to comment.