Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New AdguardSelector interface #184

Closed
ameshkov opened this issue Mar 4, 2016 · 7 comments
Closed

New AdguardSelector interface #184

ameshkov opened this issue Mar 4, 2016 · 7 comments
Assignees
@Mizzick
Labels
Enhancement
Milestone
2.3

Comments

@ameshkov
Copy link
Member

ameshkov commented Mar 4, 2016

Here is how it looks like:
layout.vpsvps.ru/adguard-assistant/

Layout attached:
archive.zip

@Mizzick assign a milestone.
@ameshkov
Copy link
Member Author

ameshkov commented Mar 4, 2016

@Mizzick

Oh, one more very important thing.

Currently all images are encoded as data: URLs.
This is restricted in AMO, so please extract it to separate files.

Ignore last two frames in layout page - this is for AG Assistant, not for browser extension.

@Mizzick Mizzick added this to the 2.3 milestone Mar 4, 2016
@Mizzick
Copy link
Contributor

Mizzick commented Mar 9, 2016

@ameshkov It would be good to have a separated and not minimized styles and fonts for assistant only.

@ameshkov
Copy link
Member Author

ameshkov commented Mar 9, 2016

Can you extract them from that archive?

Mizzick added a commit that referenced this issue Mar 10, 2016
@Mizzick
#184 assistant layout
992c70a
Mizzick added a commit that referenced this issue Mar 10, 2016
@Mizzick
#184 assistant layout
e8e26e4
Mizzick added a commit that referenced this issue Mar 10, 2016
@Mizzick
#184 assistant layout
c726816
Mizzick added a commit that referenced this issue Mar 10, 2016
@Mizzick
#184 assistant layout
da410c1
Mizzick added a commit that referenced this issue Mar 10, 2016
@Mizzick
#184 assistant layout
ceb9361
Mizzick added a commit that referenced this issue Mar 10, 2016
@Mizzick
#184 assistant layout
43b687f
Mizzick added a commit that referenced this issue Mar 10, 2016
@Mizzick
#184 assistant layout
6058e48
Mizzick added a commit that referenced this issue Mar 11, 2016
@Mizzick
#184 assistant layout
d2cbc4a
Mizzick added a commit that referenced this issue Mar 12, 2016
@Mizzick
#184 assistant layout
d06a43c
Mizzick added a commit that referenced this issue Mar 12, 2016
@Mizzick
#184 assistant layout
1ad8f52
Mizzick added a commit that referenced this issue Mar 12, 2016
@Mizzick
#184 assistant layout
eb75062
Mizzick added a commit that referenced this issue Mar 12, 2016
@Mizzick
#184 assistant layout
d0285da
Mizzick added a commit that referenced this issue Mar 12, 2016
@Mizzick
#184 assistant layout
13b571a
@Mizzick
Copy link
Contributor

Mizzick commented Mar 12, 2016

Ok, done. Need to correct some localizations now.

@ameshkov
Copy link
Member Author

Here are some very important notes:

  1. You should remove jquery and jquery UI usages from that code. As I understand, this is the only place where jquery UI is used, so we will be able to get rid of it in add-on.
  2. Upload new strings to oneskyapp

Mizzick added a commit that referenced this issue Mar 16, 2016
@Mizzick
#184 updated diff_match_patch
ac4158c
Mizzick added a commit that referenced this issue Mar 16, 2016
@Mizzick
#184 updated diff_match_patch
689b987
Mizzick added a commit that referenced this issue Mar 16, 2016
@Mizzick
#184 assistant layout
e039dce
Mizzick added a commit that referenced this issue Mar 16, 2016
@Mizzick
#184 assistant layout
b5764a9
Mizzick added a commit that referenced this issue Mar 16, 2016
@Mizzick
#184 assistant layout
169abd2
Mizzick added a commit that referenced this issue Mar 16, 2016
@Mizzick
#184 assistant layout
4053c6c
Mizzick added a commit that referenced this issue Mar 16, 2016
@Mizzick
#184 assistant layout
36a8b3b
@Mizzick
Copy link
Contributor

Mizzick commented Mar 28, 2016

New strings uploaded to oneskyapp

Mizzick added a commit that referenced this issue Mar 29, 2016
@Mizzick
#184 assistant layout
bd2e1e4
Mizzick added a commit that referenced this issue Mar 29, 2016
@Mizzick
#184 assistant layout
0fcb845
Mizzick added a commit that referenced this issue Mar 30, 2016
@Mizzick
#184 assistant layout
7d15499
Mizzick added a commit that referenced this issue Mar 31, 2016
@Mizzick
#184 assistant layout
44948c9
Mizzick added a commit that referenced this issue Mar 31, 2016
@Mizzick
#184 assistant layout
7db6208
Mizzick added a commit that referenced this issue Mar 31, 2016
@Mizzick
#184 assistant layout
06fc98e
Mizzick added a commit that referenced this issue Apr 4, 2016
@Mizzick
#184 assistant layout
6cec097
Mizzick added a commit that referenced this issue Apr 4, 2016
@Mizzick
#184 deferred
e38f168
Mizzick added a commit that referenced this issue Apr 4, 2016
@Mizzick
#184 deferred
185112c
Mizzick added a commit that referenced this issue Apr 4, 2016
@Mizzick
#184 assistant layout
877bc5e
Mizzick added a commit that referenced this issue Apr 4, 2016
@Mizzick
#184 assistant layout
2568e8b
Mizzick added a commit that referenced this issue Apr 4, 2016
@Mizzick
#184 assistant layout
7398700
Mizzick added a commit that referenced this issue Apr 4, 2016
@Mizzick
#184 assistant layout
a03ecb5
@Mizzick
Copy link
Contributor

Mizzick commented Apr 6, 2016

Waiting for translations now

Mizzick added a commit that referenced this issue Apr 14, 2016
@Mizzick
#184 assistant layout
241ff4d
Mizzick added a commit that referenced this issue Apr 14, 2016
@Mizzick
#184 assistant layout
5beaf0a
Mizzick added a commit that referenced this issue Apr 14, 2016
@Mizzick
#184 assistant layout
03a3bce
Mizzick added a commit that referenced this issue Apr 17, 2016
@Mizzick
#184 assistant layout
a837b9b
Mizzick added a commit that referenced this issue Apr 18, 2016
@Mizzick
#184 assistant layout
6ca0fb5
Mizzick added a commit that referenced this issue Apr 18, 2016
@Mizzick
#184 assistant layout
954af57
Mizzick added a commit that referenced this issue Apr 18, 2016
@Mizzick
#184 assistant layout
952601b
Mizzick added a commit that referenced this issue Apr 18, 2016
@Mizzick
#184 assistant layout
519b1c5
Mizzick added a commit that referenced this issue Apr 19, 2016
@Mizzick
#184 assistant layout
ff1531e
Mizzick added a commit that referenced this issue Apr 19, 2016
@Mizzick
#184 assistant layout
2b0d6d5
Mizzick added a commit that referenced this issue Apr 19, 2016
@Mizzick
#184 assistant layout
804033d
ameshkov pushed a commit that referenced this issue Dec 28, 2018
@maximtop
Merge pull request #184 in EXTENSIONS/browser-extension from fix/1068…
0cf4c9f 
… to feature/redesign

* commit '791ff00ca3e2ddd530ccf0c94f90b722a7e52b3b':
  remove method
  fix
  refactor clear search result event
  fix adding redundant event listeners
  es5 -> es6
  make search input listener function debounced
  change image
  add filter search logic
  remove tabs, prepare input template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizzick Mizzick

Labels
Enhancement
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
2 participants
@ameshkov @Mizzick