Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add !#else pre-processor directive support #20

Closed
ameshkov opened this issue Sep 19, 2023 · 0 comments
Closed

Add !#else pre-processor directive support #20

ameshkov opened this issue Sep 19, 2023 · 0 comments
Assignees
@slavaleleka
Labels
enhancement New feature or request Priority: P4 Resolution: Fixed Status: Closed Version: AdGuard v4.2.x (patch 2) Version: Safari v1.11.16

Comments

@ameshkov
Copy link
Member

ameshkov commented Sep 19, 2023 •
edited by slavaleleka
Loading

Makes perfect sense to have it:
AdguardTeam/CoreLibs#1806

gorhill/uBlock@194354c
@ameshkov ameshkov added the enhancement New feature or request label Sep 19, 2023
@maximtop maximtop transferred this issue from AdguardTeam/tsurlfilter Sep 19, 2023
@ameshkov ameshkov changed the title Add #else pre-processor directive support Add !#else pre-processor directive support Sep 19, 2023
@slavaleleka slavaleleka changed the title Add !#else pre-processor directive support Add support of !#else pre-processor directive Sep 22, 2023
@slavaleleka slavaleleka changed the title Add support of !#else pre-processor directive Add !#else pre-processor directive support Sep 25, 2023
@slavaleleka slavaleleka mentioned this issue Oct 2, 2023
Closed
adguard pushed a commit that referenced this issue Oct 3, 2023
@slavaleleka
support !#else directive. #20 AG-26168
afc60c5 
Squashed commit of the following:

commit a568d65
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 22:08:47 2023 +0300

    fix linter

commit 4ea3cb5
Merge: dd94c11 4e77339
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 22:07:38 2023 +0300

    merge master into the branch

commit dd94c11
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 22:03:09 2023 +0300

    fix FiltersDownloaderCreator() comment

commit e6588f7
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 19:22:29 2023 +0300

    remove not used function

commit bf0c4bf
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 16:51:22 2023 +0300

    fix jsdoc

commit b912971
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 16:49:35 2023 +0300

    add more tests

commit 5b79151
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 16:49:25 2023 +0300

    handle invalid else directive

commit 31fd9bb
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 16:26:39 2023 +0300

    fix tests

commit d50744d
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 16:17:07 2023 +0300

    improve tests

commit dbe5e67
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 15:42:44 2023 +0300

    use one function instead of findConditionEnd and findConditionElse

commit a50ddcf
Merge: 86ce098 086b55a
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Oct 2 15:18:59 2023 +0300

    Merge branch 'master' into feature/AG-26168

commit 86ce098
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Sep 29 21:13:00 2023 +0300

    add tests for else directive

commit 7f1eb3f
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Sep 29 21:12:49 2023 +0300

    add logging for tests

commit eb9fc5c
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Sep 29 21:12:23 2023 +0300

    support else directive

commit cfeba9c
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Sep 29 17:23:22 2023 +0300

    add cosmetic code fixes

commit e3e0597
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Sep 29 17:19:38 2023 +0300

    update readme
@slavaleleka slavaleleka mentioned this issue Oct 11, 2023
Merged
slavaleleka added a commit to AdguardTeam/FiltersRegistry that referenced this issue Oct 24, 2023
@slavaleleka
update compiler to v1.1.101
1e5bf7d 
AdguardTeam/FiltersDownloader#20
slavaleleka added a commit to AdguardTeam/KnowledgeBase that referenced this issue Oct 24, 2023
@slavaleleka
describe !#else directive
97ccc78 
AdguardTeam/FiltersDownloader#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
enhancement New feature or request Priority: P4 Resolution: Fixed Status: Closed Version: AdGuard v4.2.x (patch 2) Version: Safari v1.11.16
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ameshkov @adguard-bot @slavaleleka