Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter bundle does not start without Twitter4J dependency #184

Closed
cpilsworth opened this issue May 1, 2014 · 4 comments
Closed

Twitter bundle does not start without Twitter4J dependency #184

cpilsworth opened this issue May 1, 2014 · 4 comments
Milestone

Comments

@cpilsworth
Copy link
Contributor

One of the health checks we have on our site to make sure that all bundles are started. After installing the ACS AEM commons the twitter there is an installed bundle that has not started because of the missing Twitter4J dependency. There is also an error in the logs regarding an unsatisfied dependency. We could install the dependency, but as we are not using this part of the commons, this is not desirable. An alternative might be to allow a maven build profile that omits this module from the maven-content-package embededds.

@justinedelson
Copy link
Contributor

I would suggest that this HC needs to be configurable to allow for stopped bundles. Forget about the twitter bundle, how do you handle the security recommendation to stop the WebDAV and CRXDE Support bundles?

@justinedelson
Copy link
Contributor

With the change in a8a4359, we're now producing a content package with the qualifier min which is the same package, just without the twitter bundle or components. We may choose to add more filtering in the future (which is why I didn't use notwitter as the classifier).

@justinedelson
Copy link
Contributor

From a consuming project, you would reference the dependency as:

    <dependency>
        <groupId>com.adobe.acs</groupId>
        <artifactId>acs-aem-commons-content</artifactId>
        <version>1.5.3-SNAPSHOT</version>
        <type>content-package</type>
        <classifier>min</classifier>
    </dependency>

@cpilsworth
Copy link
Contributor Author

I updated our HC to check for inactive bundles, then noticed the com.adobe.granite.bundles.hc.impl.InactiveBundlesHealthCheck, which seems to do the same thing through its ignored.bundles property. Good idea for a min component anyway, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants