Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of "min" packages #2805

Closed
kwin opened this issue Mar 26, 2022 · 1 comment · Fixed by #2816
Closed

Get rid of "min" packages #2805

kwin opened this issue Mar 26, 2022 · 1 comment · Fixed by #2816

Comments

@kwin
Copy link
Contributor

kwin commented Mar 26, 2022

The min packages (introduced due to #184) contains everything except for components related to twitter (see https://adobe-consulting-services.github.io/acs-aem-commons/pages/maven.html#minimal-package and https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/content/src/main/script/CreateMinPackage.groovy).

As the dependency to twitter is dynamic anyhow from packages and optional from the bundle (

twitter4j.*;resolution:=optional,\
) there is no real advantage of using the "min" packages, except for them being a few bytes less big which isn't relevant as the total size is in total around 3.5 MB in both cases.

The dedicated twitter-acs bundle has been removed in 979121c (#1571) so the need for the dedicated packages are long gone.

@kwin
Copy link
Contributor Author

kwin commented Mar 26, 2022

@justinedelson @davidjgonzalez WDYT?

kwin added a commit that referenced this issue Apr 6, 2022
kwin added a commit that referenced this issue Apr 6, 2022
kwin added a commit that referenced this issue Apr 6, 2022
davidjgonzalez added a commit that referenced this issue Apr 15, 2022
* Remove "min" packages - This closes #2805

Co-authored-by: David G <davidjgonzalez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant