[pull] master from nvaccess:master #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…values in hits HID descriptor (#16969) Summary of the issue: In PR #16916, NVDA asks the HID braille display for its configurable number of cells. However, with the merging of that pr, trying to use some HID braille displays fails and causes a traceback this is due to the fact that some HID braille displays have no input values (number of cells property for example) in their HID descriptor. Although pr #16916 handled this correctly at its own level, the underlying hwIo.hid.Hid inputValueCaps property did not check if the number of input value caps on the descriptor was 0 before trying to fetch them. Description of user facing changes None known as this driver is still rare and the only place I've seen it is a device with custom firmware. Description of development approach For the inputButtonCaps, inputValueCaps and outputValueCaps properties on hwIo.hid.Hid, if the number of value caps in the descriptor is 0, return the unfilled 0-length array, rather than trying to fetch 0 caps (which HidP_GetButtonCaps and friends) does not like. These 0-length arrays can still be treated as iterators, which will be empty.
Summary of the issue: When updating NVDA, command line arguments are not passed from the running copy to the temporary copy. This may have security implications for arguments such as -c or --disable-addons. Description of user facing changes The -c/--config-path and --disable-addons arguments are now propagated to the temporary copy of NVDA when an update is started from within NVDA. Description of development approach Refactored updateCheck._executeUpdate to use a helper function to generate the parameters to call the launcher with. In addition to the parameters that were already passed, the following parameters are now passed: If globalVars.appArgs.disableAddons is True, the --disable-addons flag is passed. The --config-path argument is passed with the current configuration directory. We do not directly pass the path that NVDA was called with because: If -c wasn't specified at the CLI, it will be the default config path, which is what NVDA would have defaulted to anyway. If it was specified at the CLI, it will be what was specified there, as the only change we make to it is to absolutise it. Sniffing sys.argv to find -c or --config-path adds a performance overhead (and code complexity) for no benefit, because anyone fiddling around to change globalVars.appArgs.configPath or NVDAState.WritePaths.ConfigDir can change sys.argv too.
To help ensure NV Access admins do not accidentally commit and push to master, we can add a pre-commit check to protect branches from local commits. This would also aid other developers in preventing local commits to branches they cannot/shouldn't push to in their own forks accidentally, if they wish to contribute upstream. Description of user facing changes Add pre-commit hook which fails when trying to commit to a protected branch Description of development approach Add pre-commit hook which fails when trying to commit to a protected branch
Closes #8072 Summary of the issue: When cursor routing, it can sometimes be handy if speech follows along and tells you what character you moved to, especially when the character in braille is unknown to you. Description of user facing changes Added a new braille option "Speak character when routing cursor in text", disabled by default. When enabled, NVDA will speak the character you routed to after a cursor routing action. Description of development approach Added a new option to the config spec, as well as a function to braille to speak the character at the given position. Also added an item to the settings panel as well as an unbound global command.
Closes #16488 Summary of the issue: Log app architecture as part of app module info. Description of user facing changes For developers: developer info for navigator object now includes app architecture for the current app. Description of development approach Added apModule.appArchitecture to dev info list in app module class.
…eloper Guide. (#16967) Summary of the issue: While reading the dev guide, I noticed several things that could be improved. Mainly these are punctuation changes (missing commas, backticks, etc.), or wording changes to improve the English. I believe I also added a couple internal links.
Code reviews should primarily be assigned to @SaschaCowley and I currently, however we need to maintain a general GitHub team for developers. Currently reviews are being auto-assigned to the whole NV Access developer team, where their input is only necessary on certain changes. Description of approach A new team has been created for just being assigned to NVDA code reviews. Other NV Access developers still have write access to the repository, and can have a manual review requested where appropriate.
…#16974) Fixup #16779 Summary of the issue: The GitHub actions to assign milestones to closed issues and PRs is failing for community PRs. This is because the action is looking in the forks repository for the milestone ID environment variable. Description of user facing changes Fixes assigning milestones to community contributions Description of development approach using the pull_request_target event rather than pull_request, uses the target (i.e. this) repositories environment variables.
This reverts commit 19aaf75.
Revert "Create a smaller review team for general code reviews"
The docs on updating eSpeak-NG were slightly unclear, and had a couple of outdated things in them. Description of user facing changes None. Description of development approach Updated the eSpeak docs: - Made it more obvious that as well as updating user_docs/en/changes.md, you also need to update projectDocs/dev/createDevEnvironment.md (this was already included, but it was not particularly obvious to me). - Removed old references to the eSpeak version being in nvdaHelper/espeak/config.h, as it is now in nvdaHelper/espeak/sconstruct. - Fixed up markdown formatting problems.
Closes #16775 Summary of the issue: eSpeak needs to be updated for 2024.4. Description of user facing changes Added languages Faroese and Xextan to eSpeak-NG. Description of development approach Followed the update instructions. Testing strategy: Rebuilt NVDA from source. Ran NVDA, switched synth to eSpeak-NG. Tested that speech output worked fine in English. Switched voice to Faroese and Xextan and ensured that there was still output. Known issues with pull request: None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )