Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend mr update functionality #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

2-shell
Copy link

@2-shell 2-shell commented Aug 12, 2020

This PR is bigger than the previous ones. It introduces a couple of changes for making mr update (and partly also mr ls) more powerful.

Note: When #1, #2, #3, #4 are merged, this will cause substantial conflicts. If you're interested in getting this merged, please drop me a line when you've merged the other PRs, then I will rebase this one and merge any conflicts.

Note2: This will be the last PR in this manner, since I need to get ahead more quickly and doing every change in a way to be a usable PR just takes too much time. When I've finished my work for my own purposes, I can create a PR for the additional work if you're interested.

Tuschl added 5 commits August 12, 2020 12:20
For our workflow we use labels with a common prefix wit a separator
(e.g. 'CL:') for specifying the type of CL entry.

This commit adds support for using the label text after the separator
for the changelog entry type.

For this, two arguments are added for specifying the prefix and
separator (with defaults `CL` and `:`).

This information is passed on to the output logic.

To ease this, the `args` object is now passed directly to the action
functions.
This avoids defining redundant function arguments.
@Adriks976
Copy link
Owner

hi @2-shell,
Thank you for your contribution :)
I had all your previous MRs merged. I also merged one of mine who change the default output from text to json.
And for changelog, it is also possible to have different output json, html or text.
I let you review the actual master code and my changes before checking yours.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants