Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version and help should not return non-zero exit code #212

Closed
wants to merge 4 commits into from
Closed

version and help should not return non-zero exit code #212

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a957657
fixed exit codes
I3urny Aug 12, 2022
e219964
Merge branch 'master' into pr/212
vladimir-nikonov Dec 1, 2022
16e3dab
Merge branch 'master' into fix/exitcodes
I3urny Jan 9, 2023
b388e26
Merge branch 'master' into pr/212
vladimir-nikonov Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion clio/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,28 @@ private static int Main(string[] args)
(DeployCommandOptions opts) => Resolve<DeployCommand>(opts).Execute(opts),
(GetVersionOptions opts) => Resolve<GetVersionCommand>(opts).Execute(opts),
(ExternalLinkOptions opts) => Resolve<ExternalLinkCommand>(opts).Execute(opts),
errs => 1);
HandleParseError);
}

private static int HandleParseError(IEnumerable<Error> errs)
{
var exitCode = 1;

var notRealErrors = new List<ErrorType>()
{
ErrorType.VersionRequestedError,
ErrorType.HelpRequestedError,
ErrorType.HelpVerbRequestedError,
};

var isNotRealError = errs.Select(err => err.Tag)
.Intersect(notRealErrors)
.Any();

if (isNotRealError)
exitCode = 0;

return exitCode;
}

private static int SetDeveloperMode(DeveloperModeOptions opts)
Expand Down