version and help should not return non-zero exit code #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kirillkrylov @vladimir-nikonov any chance this gets released with clio 3.0.1.25? |
|
Hi, Bernhard, yes it`s possible but maybe not in 3.0.1.25, we try do it in
3.0.1.26 version (about 2 week)
Thanks
…On Tue, Aug 23, 2022 at 2:37 PM Bernhard Gally ***@***.***> wrote:
@kirillkrylov <https://github.com/kirillkrylov> @vladimir-nikonov
<https://github.com/vladimir-nikonov> any chance this gets released with
clio 3.0.1.25?
—
Reply to this email directly, view it on GitHub
<#212 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGNX4X77LVPMGFJT3SVGBKLV2TAYFANCNFSM56LTQUMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@kirillkrylov @vladimir-nikonov I've rebased my commit onto the latest master. When can I expect this to be available in clio? |
|
@vladimir-nikonov branch is up-to-date with master again. |
vladimir-nikonov
added a commit
that referenced
this pull request
Mar 16, 2023
|
fix merged in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a design choice in the CommandLineParser library that you forked the default "supported" verbs and options are listed as errors and therefore returns a non-zero exit code.
This PR fixes this by implementing a custom error handler that specifically checks for those errors.
The affected verbs and options are:
I raised an issue in the upstream repo regarding this design choice: commandlineparser/commandline#841