Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version and help should not return non-zero exit code #212

Closed
wants to merge 4 commits into from
Closed
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion clio/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,28 @@ private static int Main(string[] args) {
(DownloadConfigurationCommandOptions opts) => Resolve<DownloadConfigurationCommand>(opts).Execute(opts),
(DeployCommandOptions opts) => Resolve<DeployCommand>(opts).Execute(opts),
(GetVersionOptions opts) => Resolve<GetVersionCommand>(opts).Execute(opts),
errs => 1);
HandleParseError);
}

private static int HandleParseError(IEnumerable<Error> errs)
{
var exitCode = 1;

var notRealErrors = new List<ErrorType>()
{
ErrorType.VersionRequestedError,
ErrorType.HelpRequestedError,
ErrorType.HelpVerbRequestedError,
};

var isNotRealError = errs.Select(err => err.Tag)
.Intersect(notRealErrors)
.Any();

if (isNotRealError)
exitCode = 0;

return exitCode;
}

private static int SetDeveloperMode(DeveloperModeOptions opts) {
Expand Down