Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update APA PR according to feedback #120

Merged
merged 8 commits into from
May 5, 2024
Merged

Update APA PR according to feedback #120

merged 8 commits into from
May 5, 2024

Conversation

ANG13T
Copy link
Contributor

@ANG13T ANG13T commented Feb 24, 2024

No description provided.

ANG13T and others added 8 commits January 31, 2024 08:03
elpiel
elpiel reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. I was a bit sick the past 2 weeks so it took me some time to get back to reviewing.

You can check some of my suggestions and also run cargo fmt and cargo clippy at the end result to format and check for common guidelines for the code.

Cargo.toml Show resolved Hide resolved
src/sentences/apa.rs Show resolved Hide resolved
src/sentences/apa.rs Show resolved Hide resolved
src/sentences/apa.rs Show resolved Hide resolved
@elpiel elpiel mentioned this pull request May 5, 2024
Merged
@elpiel elpiel merged commit 9f3b646 into AeroRust:main May 5, 2024
@elpiel elpiel mentioned this pull request May 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpiel elpiel elpiel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ANG13T @elpiel