Feat: APA sentence #123
Merged
Feat: APA sentence #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 77.62% 77.96% +0.33%
==========================================
Files 34 35 +1
Lines 1247 1307 +60
==========================================
+ Hits 968 1019 +51
- Misses 279 288 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ANG13T I did my best to merge the different commits from the 2 different branches and PRs that you opened.
I also had to fix 2 issues - 1 with serde and 1 with the Cargo.toml workspace members.
Feel free to take a look and raise any issue you find, I'll merge this once all checks pass.
PRs which this PR is based on: #119 #120