Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace for Pinecone Database is Hard-Coded #48

Closed
20001LastOrder opened this issue Jul 27, 2023 · 3 comments · Fixed by #89
Closed

Namespace for Pinecone Database is Hard-Coded #48

20001LastOrder opened this issue Jul 27, 2023 · 3 comments · Fixed by #89
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@20001LastOrder
Copy link
Collaborator

Description:

Currently, when the database is set to Pinecone by providing the Pinecone API key in the .env file, the namespace used in the search is hard-coded to ReadTheDoc. (See the code here). This may cause future problems if we change the namespace or use multiple namespaces and so on.

Possible Solution:

I think the simple solution would be just to add another environment variable to the .env file and access it to get the namespace.

As the project is gaining complexity and the configuration becomes increasingly complex as well, we may also want to investigate other configuration options than the .env file, such as JSON or YAML

@20001LastOrder 20001LastOrder added enhancement New feature or request good first issue Good for newcomers labels Jul 27, 2023
@oshoma
Copy link
Collaborator

oshoma commented Aug 15, 2023

@20001LastOrder I'll work on this, and on cleaning up initialization in general. You can assign to me.

@oshoma
Copy link
Collaborator

oshoma commented Aug 15, 2023

@20001LastOrder related to this, I notice we have both OPENAI_KEY and OPENAI_API_KEY. Do we need both?

oshoma added a commit to oshoma/sherpa that referenced this issue Aug 15, 2023
1. Resolve issue Aggregate-Intellect#48
Aggregate-Intellect#48

2. Warn user and exit app if Pinecone API key is set and other Pinecone
keys are not set.
@oshoma
Copy link
Collaborator

oshoma commented Aug 15, 2023

@20001LastOrder this issue should be resolved by #89 . Please review when you have time.

oshoma added a commit to oshoma/sherpa that referenced this issue Aug 16, 2023
1. Resolve issue Aggregate-Intellect#48
Aggregate-Intellect#48

2. Warn user and exit app if Pinecone API key is set and other Pinecone
keys are not set.
oshoma added a commit to oshoma/sherpa that referenced this issue Aug 17, 2023
1. Fixes Aggregate-Intellect#48

2. Warn user and exit app if Pinecone API key is set and other Pinecone
keys are not set.
20001LastOrder pushed a commit that referenced this issue Aug 21, 2023
1. Fixes #48

2. Warn user and exit app if Pinecone API key is set and other Pinecone
keys are not set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants