App initialization #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This names all SLACK environment variables consistently. After merging this change you must rename the variable in your .env file or in the production runtime environment and restart the app.
1. Briefly document environment variables in `sample.env`. We need to update this file when we add, remove or rename environment variables. 2. Remove overlap between README.md and Tutorials/slackbot.rst. 3. Better distinguish between optional and mandatory values.
1. Move all initialization code to top of app_bolt.py. 2. Warn user and exit app when mandatory keys are undefined.
oshoma
force-pushed
the
app-initialization
branch
from
2a0e236 to
8775657
Compare
20001LastOrder
requested changes
Aug 16, 2023
1. Fixes Aggregate-Intellect#48 2. Warn user and exit app if Pinecone API key is set and other Pinecone keys are not set.
Moving forward, modules should access environment variables via config.
Usage:
First define variables in runtime environment or in your `.env` file.
Then, ...
import Config as cfg
secret = cfg.SLACK_SIGNING_SECRET
another_variable = cfg.ANOTHER_ENVIRONMENT_VARIABLE
If you are using AWS, rename these variables in your .env or production environment and restart your app to pick up the changes. ACCESS_KEY -> AWS_ACCESS_KEY SECRET_KEY -> AWS_SECRET_KEY
Rename this variable in your .env or production environment and restart your app to pick up the changes. OPENAI_KEY -> OPENAI_API_KEY
oshoma
force-pushed
the
app-initialization
branch
from
8775657 to
9c0ea28
Compare
If you are using the Github API, rename this variable in your .env or production environment and restart your app to pick up the changes. API_KEY -> GITHUB_AUTH_TOKEN
oshoma
force-pushed
the
app-initialization
branch
from
49bf9be to
370b80d
Compare
20001LastOrder
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make app initialization more robust and maintainable, and resolve #48
I don't have Pinecone set up yet, so this is worth testing with Pinecone before merging into master.