Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag options #200
Flag options #200
Changes from all commits
6722810
b6549c8
ce9b215
c4a1ff1
9741e6d
8c06434
439ac7a
47f68e2
b6eaba5
f1a00ea
53990a2
c2efe8c
c8dc1ac
3009456
56005b1
fbe5626
34bc712
b34e838
1386ce9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this test and the one above are making actual calls to 3rd party APIs. We should not do this in tests, because we may end up unknowingly hammering the 3rd party API many times.
If we're trying to test our own logic, over and above what the 3rd party API does, we should mock/stub the 3rd party API calls/responses. This will make our tests deterministic, and avoids making network calls in tests.
If we want to know whether the 3rd party API does what it claims to do, that's a different problem. We expect the 3rd party to test their own stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add the
real
mark to these tests so we can skip them if necessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. @20001LastOrder can you rename
real
to something more explicit, e.g.external-api-caller
?