Flag options #200
Flag options #200
Conversation
| def test_get_question(): | ||
| question = "What is AutoGPT and how does it compare with MetaGPT" | ||
|
|
||
| if cfg.SERPER_API_KEY is None: |
There was a problem hiding this comment.
OK. @20001LastOrder can you rename real to something more explicit, e.g. external-api-caller?
|
@20001LastOrder @YujingYang666777 I see there are also conflicts with the main branch. Please merge main into this branch to resolve conflicts. |
| def execute(self, query) -> str: | ||
| query = self.config_gsite_query(query) |
There was a problem hiding this comment.
This code adds site: to the query by calling config_gsite_query.
Then SearchTool._run adds site: to the query by calling query_with_gsqite.
(Assuming they are both using the same config.)
We should just add site to the query once, either here in GoogleSearch or in SearchTool.
If gsite is intended to be specific to google search then do the work here in GoogleSearch.
Either way I suggest calling the function query_with_gsite or something like that.
There was a problem hiding this comment.
There was a problem hiding this comment.
OK, I had a look at the implementation. It seems that this feature is meant to be added to the SearchTool, so the one in the GoogleSearch action is removed. And I moved the test accordingly.
I was able to get the same failures. I fixed some of the failed tests due to the change introduced to the search tool. However, it seems other tests also fail on the main branch. We should tackle these failure cases in a separate pr. |
|
I reduced test failures somewhat. We now have 7 failed, 33 passed, 1 skipped, 7 warnings in 678.56s (0:11:18) . |
We should use dashes instead of underscores in command line options. This confirms with the [Gnu style guide](https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html)
argparseto support different flag options to slack sherpaargparsefor more reliable results