Merge pull request #99 from syanbo/hotfix/ios-type-cast

hotfix/ios type cast crash
AgoraIO-Extensions · Sep 24, 2019 · a78dc8e · a78dc8e
2 parents 7b344e0 + b375bb3
commit a78dc8e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,8 @@
 ## THE CHANGELOG
 
+#### 2.9.0-alpha.2
+  - fix ios dictionary stringValue type cast
+
 #### 2.9.0-alpha.1
   - fix typo: rename `methodisSpeakerphoneEnabled` to `isSpeakerphoneEnabled`
   - events deprecated & instead:

diff --git a/ios/RCTAgora/RCTAgora.m b/ios/RCTAgora/RCTAgora.m
@@ -228,9 +228,9 @@ - (NSDictionary *)constantsToExport {
     }
   }
   if (options[@"secret"] != nil) {
-    [self.rtcEngine setEncryptionSecret:[options[@"secret"] stringValue]];
+    [self.rtcEngine setEncryptionSecret:[options[@"secret"]]];
     if (options[@"secretMode"] != nil) {
-      [self.rtcEngine setEncryptionMode:[options[@"secretMode"] stringValue]];
+      [self.rtcEngine setEncryptionMode:[options[@"secretMode"]]];
     }
   }
 
@@ -851,7 +851,7 @@ - (NSDictionary *)constantsToExport {
 RCT_EXPORT_METHOD(startAudioMixing:(NSDictionary *) options
                   resolve:(RCTPromiseResolveBlock)resolve
                   reject:(RCTPromiseRejectBlock)reject) {
-  NSInteger res = [self.rtcEngine startAudioMixing:[options[@"filepath"] stringValue]
+  NSInteger res = [self.rtcEngine startAudioMixing:[options[@"filepath"]]
                                           loopback:[options[@"loopback"] boolValue]
                                            replace:[options[@"replace"] boolValue]
                                              cycle:[options[@"cycle"] integerValue]];
@@ -1038,7 +1038,7 @@ - (NSDictionary *)constantsToExport {
                   resolve:(RCTPromiseResolveBlock)resolve
                   reject:(RCTPromiseRejectBlock)reject) {
   NSInteger res = [self.rtcEngine playEffect:(int)[options[@"soundid"] integerValue]
-                                    filePath:[options[@"filepath"] stringValue]
+                                    filePath:[options[@"filepath"]]
                                    loopCount:(int)[options[@"loopcount"] integerValue]
                                        pitch:[options[@"pitch"] doubleValue]
                                          pan:[options[@"pan"] doubleValue]
@@ -1157,7 +1157,7 @@ - (NSDictionary *)constantsToExport {
                   resolve:(RCTPromiseResolveBlock)resolve
                   reject:(RCTPromiseRejectBlock)reject) {
   AgoraAudioRecordingQuality qualityType = (AgoraAudioRecordingQuality)[options[@"quality"] integerValue];
-  NSInteger res = [self.rtcEngine startAudioRecording:[options[@"filepath"] stringValue] quality:qualityType];
+  NSInteger res = [self.rtcEngine startAudioRecording:[options[@"filepath"]] quality:qualityType];
   if (res == 0) {
     resolve(nil);
   } else {
@@ -1374,7 +1374,7 @@ - (NSDictionary *)constantsToExport {
   config.audioBitrate = [options[@"config"][@"audioBitrate"] integerValue];
   config.audioChannels = [options[@"config"][@"audioChannels"] integerValue];
 
-  NSInteger res = [self.rtcEngine addInjectStreamUrl:[options[@"url"] stringValue]
+  NSInteger res = [self.rtcEngine addInjectStreamUrl:[options[@"url"]]
                                               config:config];
   if (res == 0) {
     resolve(nil);
@@ -1630,7 +1630,7 @@ - (NSDictionary *)constantsToExport {
     transcoding.transcodingUsers = transcodingUsers;
   }
   if ([options objectForKey:@"transcodingExtraInfo"]) {
-    transcoding.transcodingExtraInfo = [options[@"transcodingExtraInfo"] stringValue];
+    transcoding.transcodingExtraInfo = [options[@"transcodingExtraInfo"]];
   }
 
   NSInteger res = [self.rtcEngine setLiveTranscoding:transcoding];