publish 'use' images #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
25-publish-use
branch
9 times, most recently
from
f279c15 to
d31559a
Compare
turadg
force-pushed
the
25-publish-use
branch
from
d31559a to
ccd7f21
Compare
mhofman
reviewed
Jan 18, 2024
Comment on lines
+115
to
+124
| - name: Push proposal "use" images | ||
| uses: docker/bake-action@v4 |
There was a problem hiding this comment.
I fail to see anywhere how a use image is prefixed with pr-NN- before pushing.
There was a problem hiding this comment.
This isn't meant to push tags for "use" images out of PR builds. It does for review but once the PR is approved I'll change it to only push from the default branch. That sidesteps the issue of distinguishing use images by branch origin.
Well that answers my question. If we could figure out prefixing, it might be nice to avoid overriding, at least for the case where we manually trigger a workflow.
There was a problem hiding this comment.
Agree it "might be nice" . I don't think we need it to deliver #25. Let's tackle if a need presents itself.
turadg
force-pushed
the
25-publish-use
branch
from
ccd7f21 to
bd72b61
Compare
michaelfig
approved these changes
Jan 19, 2024
turadg
force-pushed
the
25-publish-use
branch
from
4f26603 to
2d033f9
Compare
turadg
force-pushed
the
25-publish-use
branch
from
2d033f9 to
a0b92e4
Compare
turadg
force-pushed
the
25-publish-use
branch
from
a0b92e4 to
9285e9b
Compare
This was referenced Jan 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #25
Publishes "use" images so that consumers can rely on a certain state of state of the chain. They're published as tags matching the target, like
use-upgrade-9. I experimented with having separate images names such as a3p-use-upgrade8 but we agreed it's better to just use tags. They're all visible at https://ghcr.io/agoric/agoric-3-proposals.This isn't meant to push tags for "use" images out of PR builds. It does for review but once the PR is approved I'll change it to only push from the default branch. That sidesteps the issue of distinguishing use images by branch origin.
This PR has some other cleanup and refactoring along the way. I recommend reviewing by commit.