Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit vaultFactory package for consistency #4415

Open
turadg opened this issue Jan 28, 2022 · 6 comments
Open

Audit vaultFactory package for consistency #4415

turadg opened this issue Jan 28, 2022 · 6 comments
Assignees
@turadg
Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Vaults VaultFactor (née Treasury)

Comments

@turadg
Copy link
Member

turadg commented Jan 28, 2022

What is the Problem Being Solved?

vaultFactory has grown somewhat organically and it's time to take a look holistically to tie it all together so that it's easy to comprehend and maintain.

Examples of things to look into:

  • Consistent patterns
    -- invitations
  • Contract modularity
    -- AMM from vaultFactory to bootstrap

Description of the Design

Output of ticket will be proposal for design changes.

Security Considerations

n/a

Test Plan

n/a
@turadg turadg added enhancement New feature or request restival to be done before RUN Protocol Purple Team festival labels Jan 28, 2022
@turadg turadg self-assigned this Feb 1, 2022
@turadg turadg added the Core Economy OBSOLETE in favor of INTER-protocol label Feb 1, 2022
@Tartuffo Tartuffo added MN-1 and removed MN-1 labels Feb 2, 2022
@dckc
Copy link
Member

dckc commented Feb 8, 2022

I suggest closing this as a dup of #4199 (resolved in #4209). I don't see any new information that motivates reconsidering that decision.

@turadg
Copy link
Member Author

turadg commented Feb 8, 2022

This was filed at the request of @dtribble in late January when he had some thoughts on things to revisit.

I don't see any new information that motivates reconsidering that decision.

I don't think that decision is in doubt. However "new information" on whether to make changes before Mainnet 1 is actually the output of this work, not the input.

@turadg
Copy link
Member Author

turadg commented Feb 23, 2022

Example to come back to: fcdd7a0

@turadg turadg mentioned this issue Feb 23, 2022
Merged
@dtribble dtribble mentioned this issue Mar 1, 2022
Merged
@turadg turadg mentioned this issue Mar 2, 2022
Merged
dtribble added a commit that referenced this issue Mar 2, 2022
@dtribble
refactor(run-protocol): rename ReallocateReward to reallocateWithFee (#…
4862120 
…4712)

refactor(run-protocol): rename ReallocateReward to reallocateWithFee

Refs: #4415
@Chris-Hibbert Chris-Hibbert added the Vaults VaultFactor (née Treasury) label Mar 10, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@turadg
Copy link
Member Author

turadg commented May 5, 2022

Some observations from @erights #4553

@turadg turadg mentioned this issue Jun 10, 2022
Merged
@Tartuffo Tartuffo removed this from the Mainnet 1 milestone Jul 19, 2022
@Tartuffo
Copy link
Contributor

Closing this because it seems to be done.

@turadg
Copy link
Member Author

turadg commented Jul 20, 2022

Reopening because it's not done and it doesn't delay MN-1 because it's not scheduled for MN-1.

@turadg turadg reopened this Jul 20, 2022
@ivanlei ivanlei removed the restival to be done before RUN Protocol Purple Team festival label Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request Vaults VaultFactor (née Treasury)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@turadg @dckc @Tartuffo @ivanlei @Chris-Hibbert