New package for run-protocol; rename Treasury/stablecoin #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
dependencies
Chris-Hibbert
force-pushed
the
renameTreasury
branch
3 times, most recently
from
bde898d
to
be5c2b8
Compare
Chris-Hibbert
force-pushed
the
renameTreasury
branch
2 times, most recently
from
25c2117
to
5d1b0d2
Compare
dckc
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
With all this stuff moving around, I checked to be sure none of the tests got lost:
before:
42 tests passed
Done in 104.63s.
-- https://github.com/Agoric/agoric-sdk/runs/4652895194?check_suite_focus=true#step:5:940
after:
42 tests passed
Done in 125.11s.
-- https://github.com/Agoric/agoric-sdk/runs/4645856395?check_suite_focus=true#step:5:940
rename treasury package to run-protocol. rename stablecoinMachine (and stablecoin) to vaultFactory changes to documentation will be done separately The Dapps will be updated in linked PRs as necessary.
Chris-Hibbert
force-pushed
the
renameTreasury
branch
from
5d1b0d2
to
150238a
Compare
mhofman
added a commit
to Agoric/testnet-load-generator
that referenced
this pull request
Jan 8, 2022
The name of the Treasury changed to VaultFactory in Agoric/agoric-sdk#4209. Pick whichever is available for backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #4199
dapp-treasury updates are in Agoric/dapp-treasury#59
Description
Rename treasury package to run-protocol.
rename stablecoinMachine (and stablecoin) to vaultFactory
changes to documentation will be done separately
The Dapps will be updated in linked PRs as necessary.
Security Considerations
No security implications. this is just renaming and moving things around. At the end, the RUN protocol contracts will be grouped together.
Documentation Considerations
The external documentation doesn't reflect the internal organization. VaultFactory (renamed from Treasury), the AMM, and other RUN protocol contracts should be extracted as separate category of Zoe contracts.
Testing Considerations
Existing tests should be sufficient.