-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Durable objects for governance #5200
Comments
The tester issue is #4997 |
Hello @FUDCo I am looking to assign this ticket to someone for the sake of tracking. Would you be the correct choice? |
I'm already working on this. I'll change the assignee. |
thanks @Chris-Hibbert |
After upgrading vaultFactory, A slog visualization slog.svg shows v41 (zcf-b1-9f877-vaultFactory.governor) receives a vat terminated rejection. It looks like the resolution of agoric-sdk/packages/governance/src/contractGovernorKit.js Lines 112 to 117 in ba3b776
|
…9953) refs: #5200 ## Description Do a null upgrade of the vaultFactory governor contract in the coreEval that upgrades the vaultFactory contract. ### Security Considerations If the governor is correctly connected to the contract (tests in process), and can govern parameters and enable offer filters, then everything is connected as it was, and there are no new security issues. ### Scaling Considerations None. ### Documentation Considerations No user-visible changes. ### Testing Considerations Test governance of the vaultFactory thoroughly on a testnet. ### Upgrade Considerations It appears that contract governor may be upgradeable..
What is the Problem Being Solved?
Governance state must survive vat upgrade.
For MainNet 1, we intend to support durable objects for restart and upgrade.
However, @Chris-Hibbert has determined that we can make upgrade work without durability because we store the outcomes of votes that affect parameter values. Since #5678 the parameter changes are recorded off-chain. So while this is important it's not a 1.0 launch blocker.
Description of the Design
Convert Virtual objects #4343 to Durable.
Security Considerations
Trust of statement management by storage system and disk.
Test Plan
Use new durability tester h/t @FUDCo
The text was updated successfully, but these errors were encountered: