Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make governance system allow governed contracts to be upgradable #7248

Closed
turadg opened this issue Mar 27, 2023 · 0 comments · Fixed by #7439
Closed

make governance system allow governed contracts to be upgradable #7248

turadg opened this issue Mar 27, 2023 · 0 comments · Fixed by #7439
Assignees
Labels
enhancement New feature or request Governance Governance vaults_triage DO NOT USE
Milestone

Comments

@turadg
Copy link
Member

turadg commented Mar 27, 2023

What is the Problem Being Solved?

All contracts after bulldozer have to be upgradable. We've decided that none of the governance state is precious (because it's all published publicly) so we don't need durable storage:

Moreover, the security assurances of governance may be violated by passing baggage through to handleGovernance of the governed contract.

Description of the Design

The contracts are upgradable and have some some way to restore the governance state.

Security Considerations

Scaling Considerations

Test Plan

A swingset or bootstrap test that upgrades a governed contract

@turadg turadg added the enhancement New feature or request label Mar 27, 2023
@turadg turadg self-assigned this Mar 27, 2023
@turadg turadg added the Governance Governance label Mar 27, 2023
@turadg turadg added this to the Vaults EVP milestone Mar 30, 2023
@ivanlei ivanlei added the vaults_triage DO NOT USE label Apr 3, 2023
@turadg turadg changed the title make governance contracts upgradable make governance system all governed contracts to be upgradable Apr 17, 2023
@turadg turadg changed the title make governance system all governed contracts to be upgradable make governance system allow governed contracts to be upgradable Apr 17, 2023
@mergify mergify bot closed this as completed in #7439 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Governance Governance vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants