Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6853 upgrade flux #7439

Merged
merged 7 commits into from
Apr 19, 2023
Merged

6853 upgrade flux #7439

merged 7 commits into from
Apr 19, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Apr 17, 2023

closes: #7248
closes: #6853

Description

This makes fluxAggregator upgradable.

To do so it also has to solve #7248. They're in separate commits. I kept them in this PR because fluxAggregator upgrade demonstrates the changes sufficing.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

@turadg turadg requested review from dckc and Chris-Hibbert April 17, 2023 23:04
@turadg turadg force-pushed the 6853-upgrade-flux branch 2 times, most recently from eb208c0 to 6d3db5a Compare April 18, 2023 00:49
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly like the right direction. The unavailable paramManager values worry me. Can we get access to them (in tests) by waiting longer?

@turadg turadg force-pushed the 6853-upgrade-flux branch 2 times, most recently from 250599a to 4276860 Compare April 18, 2023 21:01
@turadg turadg marked this pull request as ready for review April 18, 2023 21:02
@turadg turadg requested a review from Chris-Hibbert April 18, 2023 21:02
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction looks good. I'm still concerned about the missing initial update. Plz let me know what you figure out.

packages/inter-protocol/src/price/fluxAggregatorKit.js Outdated Show resolved Hide resolved
packages/inter-protocol/src/price/fluxAggregatorKit.js Outdated Show resolved Hide resolved
@turadg turadg requested a review from Chris-Hibbert April 18, 2023 23:23
@turadg turadg force-pushed the 6853-upgrade-flux branch from 031418b to ed9b636 Compare April 19, 2023 18:26
@turadg turadg removed the request for review from dckc April 19, 2023 18:33
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have skimmed this a little. If you need me to take a closer look, LMK. Otherwise, I defer to @Chris-Hibbert

Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work-arounds. They resolve my concerns.

LGTM

@turadg turadg force-pushed the 6853-upgrade-flux branch from ed9b636 to 3e5b4c5 Compare April 19, 2023 19:07
@turadg turadg added the automerge:no-update (expert!) Automatically merge without updates label Apr 19, 2023
@mergify mergify bot merged commit 143df2a into master Apr 19, 2023
@mergify mergify bot deleted the 6853-upgrade-flux branch April 19, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make governance system allow governed contracts to be upgradable make price aggregator contract upgradable
3 participants