Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaults bootstrap includes extra bundle: vat-network #7044

Closed
Tracked by #6553
ivanlei opened this issue Feb 22, 2023 · 2 comments · Fixed by #7623
Closed
Tracked by #6553

vaults bootstrap includes extra bundle: vat-network #7044

ivanlei opened this issue Feb 22, 2023 · 2 comments · Fixed by #7623
Assignees
Labels
bug Something isn't working cosmic-swingset package: cosmic-swingset vaults_triage DO NOT USE
Milestone

Comments

@ivanlei
Copy link
Contributor

ivanlei commented Feb 22, 2023

What is the Problem Being Solved?

vat-network is not being used in the vaults release. by removing it from the bootstrap we can avoid having to worry about it being durable or upgradeable. This allows us to defer #5973

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

@ivanlei ivanlei added enhancement New feature or request vaults_triage DO NOT USE labels Feb 22, 2023
@ivanlei ivanlei added this to the Vaults EVP milestone Feb 22, 2023
@dckc dckc changed the title Remove vat-network from vaults related bootstrap vaults bootstrap includes extra bundle: vat-network Feb 22, 2023
@dckc dckc added bug Something isn't working cosmic-swingset package: cosmic-swingset and removed enhancement New feature or request labels Feb 22, 2023
@dckc
Copy link
Member

dckc commented Feb 22, 2023

@dckc
Copy link
Member

dckc commented May 1, 2023

network vat is mostly about IBC, but see also https://github.com/Agoric/agoric-sdk/blob/master/packages/SwingSet/docs/networking.md

need to have some plan to preserve viability of...

@ivanlei ivanlei assigned samsiegart and michaelfig and unassigned dckc and samsiegart May 1, 2023
warner added a commit that referenced this issue May 5, 2023
Previously, certain configurations included vat-ibc and vat-network
code as part of bootstrap.

These two vats are not properly upgradable, and are not used in our
initial launch configuration. To minimize risk, we don't want unused
code running on-chain, however we have development and test
configurations which *do* need IBC support, so we don't want to delete
this code entirely.

This commit removes ibc/network from `config.bundles`, and instead
creates "proposals" for them (just like we do for Pegasus and the
Inter protocol). You can run `agoric run
packages/vats/scripts/init-network.js` to create both a set of bundles
for installation, and a proposal file to submit in a transaction. Once
executed, this will cause the target chain to create vat-network and
vat-ibc, and to wire them up just as if they were included at
bootstrap time.

closes #7044
warner added a commit that referenced this issue May 5, 2023
Previously, certain configurations included vat-ibc and vat-network
code as part of bootstrap.

These two vats are not properly upgradable, and are not used in our
initial launch configuration. To minimize risk, we don't want unused
code running on-chain, however we have development and test
configurations which *do* need IBC support, so we don't want to delete
this code entirely.

This commit removes ibc/network from `config.bundles`, and instead
creates "proposals" for them (just like we do for Pegasus and the
Inter protocol). You can run `agoric run
packages/vats/scripts/init-network.js` to create both a set of bundles
for installation, and a proposal file to submit in a transaction. Once
executed, this will cause the target chain to create vat-network and
vat-ibc, and to wire them up just as if they were included at
bootstrap time.

closes #7044
warner added a commit that referenced this issue May 5, 2023
Previously, certain configurations included vat-ibc and vat-network
code as part of bootstrap.

These two vats are not properly upgradable, and are not used in our
initial launch configuration. To minimize risk, we don't want unused
code running on-chain, however we have development and test
configurations which *do* need IBC support, so we don't want to delete
this code entirely.

This commit removes ibc/network from `config.bundles`, and instead
creates "proposals" for them (just like we do for Pegasus and the
Inter protocol). You can run `agoric run
packages/vats/scripts/init-network.js` to create both a set of bundles
for installation, and a proposal file to submit in a transaction. Once
executed, this will cause the target chain to create vat-network and
vat-ibc, and to wire them up just as if they were included at
bootstrap time.

closes #7044
warner added a commit that referenced this issue May 5, 2023
Previously, certain configurations included vat-ibc and vat-network
code as part of bootstrap.

These two vats are not properly upgradable, and are not used in our
initial launch configuration. To minimize risk, we don't want unused
code running on-chain, however we have development and test
configurations which *do* need IBC support, so we don't want to delete
this code entirely.

This commit removes ibc/network from `config.bundles`, and instead
creates "proposals" for them (just like we do for Pegasus and the
Inter protocol). You can run `agoric run
packages/vats/scripts/init-network.js` to create both a set of bundles
for installation, and a proposal file to submit in a transaction. Once
executed, this will cause the target chain to create vat-network and
vat-ibc, and to wire them up just as if they were included at
bootstrap time.

test-boot-config.js: NON_UPGRADEABLE_VATS now asserts that
'vat-network' and 'vat-ibc' do not appear in the config. The 'pegasus'
vat was removed earlier, so I uncommented that line too.

test-boot-config.js: TODO: we removed 'setupNetworkProtocols' and
'networkVat' as expected, but it looks like we also removed 'zoe',
'provisioning', and 'bridgeManager'. Why?

closes #7044
warner added a commit that referenced this issue May 5, 2023
Previously, certain configurations included vat-ibc and vat-network
code as part of bootstrap.

These two vats are not properly upgradable, and are not used in our
initial launch configuration. To minimize risk, we don't want unused
code running on-chain, however we have development and test
configurations which *do* need IBC support, so we don't want to delete
this code entirely.

This commit removes ibc/network from `config.bundles`, and instead
creates "proposals" for them (just like we do for Pegasus and the
Inter protocol). You can run `agoric run
packages/vats/scripts/init-network.js` to create both a set of bundles
for installation, and a proposal file to submit in a transaction. Once
executed, this will cause the target chain to create vat-network and
vat-ibc, and to wire them up just as if they were included at
bootstrap time.

test-boot-config.js: NON_UPGRADEABLE_VATS now asserts that
'vat-network' and 'vat-ibc' do not appear in the config. The 'pegasus'
vat was removed earlier, so I uncommented that line too.

closes #7044
@warner warner self-assigned this May 5, 2023
@mergify mergify bot closed this as completed in #7623 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cosmic-swingset package: cosmic-swingset vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants