Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first cut at making the network vat upgradable.
It also includes a refactoring that moves the network vat code from being in a mix of the
SwingSet
package and thevats
package to being 100% in thevats
package.Currently it passes all the tests I could find that in any way implicate the network vat (in the
vats
,solo
,cosmic-swingset
, andpegasus
packages). However, while it now keeps all of its state that I could identify in durable storage, there is as yet no test as to whether it actually achieves upgradability. As such, this PR should be viewed as a step on the road to achieving upgradability without yet making any assertions as to whether that destination has in fact been reached. Consequently I would leave the motivating issue (#5696) open for the time being.I have made an unsuccessful first cut at attempting to test upgradability, but various complications with the current network vat tests (most notably that these tests don't actually run in a swingset) have meant that while the proposed testing strategy that @michaelfig pointed me at seems to be sound (basically, a network vat restart in the middle of the
test network - ibc
test), the existing tests themselves do not lend themselves to being adapted in this way. This is work for the future but I believe we have concluded that it is not on the current critical path.