Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace pipeTopicToStorage with new utilities #7300

Closed
Tracked by #7297
turadg opened this issue Mar 31, 2023 · 0 comments · Fixed by #7389
Closed
Tracked by #7297

replace pipeTopicToStorage with new utilities #7300

turadg opened this issue Mar 31, 2023 · 0 comments · Fixed by #7389
Assignees
Labels
enhancement New feature or request vaults_triage DO NOT USE

Comments

@turadg
Copy link
Member

turadg commented Mar 31, 2023

What is the Problem Being Solved?

pipeTopicToStorage retains the storageNode and marshaller.

Description of the Design

Use an newer prepareDurablePublishKit:

The maker it returns takes an argument for a callback whenever a value is published. That's where the "pipe to storage" will happen, one at a time. That callback itself will be made durable with a prepare function such as prepareStorageWriter.

The contract root can abstract this with a power that it passes down,

const makeDurablePublishKit = prepareDurablePublishKit(baggage, diagnosticName);
const makeStorageWriter = prepareStorageWriter(marshaller);
const makeStoredPublishKit = storageNode => makeDurablePublishKit(makeStorageWriter(storageNode));

Security Considerations

Scaling Considerations

Test Plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants