forEachPublicationRecord is not sufficiently virtual

[mhofman]

Describe the bug

pipeTopicToStorage was made as a replacement for makeStoredPublishKit that is compatible with durable publish kits but it kept using forEachPublicationRecord, which keeps all objects in heap: the storageNode (through consumeValue), the subscriber and its iterator.

Instead forEachPublicationRecord should use the watchPromise pattern, using a durable or virtual promise handler as appropriate for the use case.

Expected behavior

No heap usage related to the usage of pipeTopicToStorage or makeStoredPublishKit.

No use of forEachPublicationRecord (explicitly or transitively) in durable contracts.

Additional context

Found while investigating #7297

[turadg]

Note that this limitation of pipeTopicToStorage was understood at the time it was created. #6893 was queued up to solve it.

Now that we have #7303 I propose that we simply remove pipeTopicToStorage. That can be part of #7300

We still need to decide about other uses of forEachPublicationRecord. I propose that this issue be scoped to that.

[turadg]

Given that we have #7300 I've rescoped this to fixing/removing forEachPublicationRecord.