Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault creation grows heap #7297

Open
5 tasks done
turadg opened this issue Mar 31, 2023 · 0 comments
Open
5 tasks done

Vault creation grows heap #7297

turadg opened this issue Mar 31, 2023 · 0 comments
Assignees
Labels

Comments

@turadg
Copy link
Member

turadg commented Mar 31, 2023

What is the Problem Being Solved?

With #7218 we learned that creating more vaults grows the heap. I.e. some objects are being retained through the vault creation that shouldn't be.

Description of the Design

Find all the retaining paths and fix them. So far,

Retention fixes

Preview Give feedback
  1. automerge:rebase
  2. automerge:rebase
  3. enhancement notifier performance vaults_triage
    gibson042
  4. enhancement vaults_triage
    turadg
  5. enhancement notifier vaults_triage
    gibson042

Then add regression tests (see Test Plan).

Security Considerations

Scaling Considerations

Test Plan

We need a test that checks memory usage growth. This may be achievable by process.memoryUsage() comparison after vault runs. See #7296 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants